Skip to content

Extract rule: template-splat-attributes-only#2621

Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-splat-attributes-only
Mar 19, 2026
Merged

Extract rule: template-splat-attributes-only#2621
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-splat-attributes-only

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

Copy link
Copy Markdown

@NullVoxPopuli-ai-agent NullVoxPopuli-ai-agent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review: template-splat-attributes-only

Compared against ember-template-lint splat-attributes-only.js.

General Correctness

  1. Faithful port: This is a clean, minimal rule and the ESLint port matches the original perfectly. The original checks AttrNode where node.name.startsWith('...') and node.name !== '...attributes', and the port does exactly the same with GlimmerAttrNode. The error message matches. Well done.

  2. Error message: Matches the original exactly: 'Only \...attributes` can be applied to elements'`. Good.

  3. Tests: Cover the main cases. The hbs tests include ...arguments as invalid. The gjs tests additionally test ...props. Good coverage.

  4. No issues found: This is a straightforward structural check with no edge cases to worry about.

Scope Analysis (gjs/gts)

This rule only checks attribute names (structural/syntactic property). It does not match any helper or component names. No scope analysis needed.


🤖 Automated review comparing with ember-template-lint source

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-splat-attributes-only branch from bd35d5f to 776ee42 Compare March 19, 2026 18:14
@NullVoxPopuli NullVoxPopuli merged commit 9c58f41 into ember-cli:master Mar 19, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants