Extract rule: template-no-unknown-arguments-for-builtin-components

[NullVoxPopuli]

Split from #2371.

[NullVoxPopuli-ai-agent]

Review: template-no-unknown-arguments-for-builtin-components (comparing with ember-template-lint no-unknown-arguments-for-builtin-components)

Coverage

This is the most complex rule in this batch. The migration covers the core detection logic well.

What's done well

• Complete KnownArguments data: The argument maps for LinkTo, Input, and Textarea are identical to the original -- all deprecated arguments, deprecated events, conflicts, and required argument lists are faithfully reproduced.
• Error message functions (deprecateArgument, deprecateEvent) produce the same messages as the original.
• Conflict detection is correctly implemented.
• Comprehensive tests: Both gjs and hbs modes tested with a good variety of cases (typos, deprecated args, deprecated events, conflicts, unknown args).
• templateMode: 'both' is appropriate since <Input>, <Textarea>, and <LinkTo> exist in both modes.

Items needing attention

1. Fuzzy matching differs from original: The original uses fuse.js for fuzzy matching, while this PR implements a custom fuzzyMatch function. This means suggestion quality may differ. For example, in the HBS test, @random suggests @dragEnd -- the original with Fuse.js may produce a different suggestion. This is a pragmatic tradeoff (avoiding a new dependency), but worth documenting.

2. Missing required argument validation: The original rule checks nodeMeta.required and reports when none of the required argument variants are present (e.g., LinkTo requires at least one of @route, @query, @model, or @models). The required data is present in KnownArguments but the create() function does not check it. This means cases like <LinkTo /> (with no route-related arguments) will not produce an error. The original has a REQUIRED_MESSAGE function and corresponding logic.

3. Missing fixability: The original rule supports auto-fixing deprecated arguments (converting @elementId to id, converting deprecated events to {{on}} modifiers). The ESLint version has fixable: null, so no auto-fix is provided. This is understandable given the complexity of AST manipulation in the ESLint context, but worth noting as a feature gap.

4. Conflict message wording difference: The original uses "only one should exists" (with typo). The PR uses "only one should exist." (corrected). This is actually an improvement, but test assertions should match.

Verdict

Good migration overall, especially given the complexity. The missing required argument check is the most significant gap -- it means <LinkTo /> without any route/query/model args won't be flagged. Consider adding that check or documenting it as a known limitation.

---

🤖 Automated review comparing with ember-template-lint source