Extract rule: template-no-unbound#2582
Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom Mar 21, 2026
Merged
Conversation
NullVoxPopuli-ai-agent
left a comment
There was a problem hiding this comment.
Review: template-no-unbound (comparing with ember-template-lint no-unbound)
Coverage
The migration looks clean and faithfully reproduces the original rule. The original checks MustacheStatement, BlockStatement, and SubExpression -- this PR correctly maps those to GlimmerMustacheStatement, GlimmerBlockStatement, and GlimmerSubExpression.
What's done well
- Correct node type mapping: All three visitor types from the original are covered.
- Error message: Closely matches the original (
"Unexpected {{unbound}} usage."vs original"Unexpected {{unbound}} usage."). Essentially identical. - Good test coverage: Both
.gjs/.gts(viaember-eslint-parser) and.hbs(viaember-eslint-parser/hbs) are tested. templateMode: 'loose'is appropriate sinceunboundis a legacy helper that wouldn't appear in strict mode.- Clean, minimal implementation -- easy to review and maintain.
Observations
- The original rule checks
node.path.original === 'unbound'directly without the?.typeguard. The PR addsnode.path?.type === 'GlimmerPathExpression'which is a reasonable defensive check for the ESLint AST. Good. - The original test has 2 valid and 2 invalid cases. The PR has 3 valid (adds
{{this.value}}for gjs) and 2 invalid per parser mode -- adequate coverage.
Verdict
This is a straightforward, correct migration. No issues found.
🤖 Automated review comparing with ember-template-lint source
dd11c1f to
3ba27aa
Compare
This was referenced Mar 21, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.