Skip to content

Post-merge review of #2484 (template-no-nested-interactive) #2504

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
NullVoxPopuli merged 3 commits into from
Mar 13, 2026
Merged

Post-merge review of #2484 (template-no-nested-interactive) #2504

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a1ac2a1
Fix template-no-nested-interactive: accept both ignoreUsemap and igno…
johanrd Mar 12, 2026
42dc391
Add ignoreUsemapAttribute alias to docs Options table
johanrd Mar 13, 2026
b5360d9
Fix docs: prettier table alignment
johanrd Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions docs/rules/template-no-nested-interactive.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,12 +99,13 @@ Examples of **correct** code for this rule:

## Options

| Name | Type | Default | Description |
| --------------------------- | ---------- | ------- | ----------------------------------------------------------- |
| `additionalInteractiveTags` | `string[]` | `[]` | Extra tag names to consider interactive. |
| `ignoredTags` | `string[]` | `[]` | Tag names to skip checking. |
| `ignoreTabindex` | `boolean` | `false` | If `true`, `tabindex` does not make an element interactive. |
| `ignoreUsemap` | `boolean` | `false` | If `true`, `usemap` does not make an element interactive. |
| Name | Type | Default | Description |
| --------------------------- | ---------- | ------- | ------------------------------------------------------------- |
| `additionalInteractiveTags` | `string[]` | `[]` | Extra tag names to consider interactive. |
| `ignoredTags` | `string[]` | `[]` | Tag names to skip checking. |
| `ignoreTabindex` | `boolean` | `false` | If `true`, `tabindex` does not make an element interactive. |
| `ignoreUsemap` | `boolean` | `false` | If `true`, `usemap` does not make an element interactive. |
| `ignoreUsemapAttribute` | `boolean` | `false` | Alias for `ignoreUsemap` (original ember-template-lint name). |

## References

Expand Down
3 changes: 2 additions & 1 deletion lib/rules/template-no-nested-interactive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@ module.exports = {
ignoredTags: { type: 'array', items: { type: 'string' } },
ignoreTabindex: { type: 'boolean' },
ignoreUsemap: { type: 'boolean' },
ignoreUsemapAttribute: { type: 'boolean' },
},
additionalProperties: false,
},
Expand All @@ -99,7 +100,7 @@ module.exports = {
const additionalInteractiveTags = new Set(options.additionalInteractiveTags || []);
const ignoredTags = new Set(options.ignoredTags || []);
const ignoreTabindex = options.ignoreTabindex || false;
const ignoreUsemap = options.ignoreUsemap || false;
const ignoreUsemap = options.ignoreUsemap || options.ignoreUsemapAttribute || false;

const interactiveStack = [];
// Stack for saving/restoring label interactiveChildCount across GlimmerBlock boundaries
Expand Down
Loading