Post-merge review of #2395 (template-link-href-attributes)#2494
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Mar 13, 2026
Merged
Post-merge review of #2395 (template-link-href-attributes)#2494NullVoxPopuli merged 1 commit intoember-cli:masterfrom
template-link-href-attributes)#2494NullVoxPopuli merged 1 commit intoember-cli:masterfrom
Conversation
Add missing exception from original: <a> with both role and aria-disabled should not require href. Also add test cases for edge cases.
NullVoxPopuli
approved these changes
Mar 13, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Missing exception for
<a>elements with bothroleandaria-disabledattributes, causing false positives on accessible patterns like<a role="link" aria-disabled="true">. The original skips reporting when both are present — seelink-href-attributes.jslines 27–29.Cowritten by claude