Skip to content

Extract rule: template-no-bare-yield#2457

Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-bare-yield
Mar 13, 2026
Merged

Extract rule: template-no-bare-yield#2457
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-bare-yield

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-yield branch 2 times, most recently from 35413c0 to 4d7688c Compare March 10, 2026 22:25
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Review from claude: comparing against ember-template-lint no-yield-only

⚠️Fundamentally different semantics. The original only flags templates whose entire content is a bare {{yield}} — nothing else (whitespace and comments excluded). It's about preventing wrapper components
that just pass through their block with no added value.

The PR flags any {{yield}} without parameters, regardless of what else is in the template. This is a much broader rule:

{{!-- Original: OK (yield is not the only content). PR: flagged --}}                                                                                                                                               
<div>{{yield}}</div>                                                                                                                                                                                             
                                                                                                                                                                                                                   
{{!-- Original: flagged (yield is the only content). PR: also flagged --}}                                                                                                                                       
{{yield}}                                                                                                                                                                                                          

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-yield branch from 4d7688c to 9830b2e Compare March 13, 2026 15:14
@NullVoxPopuli NullVoxPopuli merged commit aaf9e75 into ember-cli:master Mar 13, 2026
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-bare-yield branch March 13, 2026 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants