Skip to content

Extract rule: template-no-at-ember-render-modifiers#2456

Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-at-ember-render-modifiers
Mar 13, 2026
Merged

Extract rule: template-no-at-ember-render-modifiers#2456
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-at-ember-render-modifiers

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-at-ember-render-modifiers branch 2 times, most recently from de84265 to f7fda7a Compare March 10, 2026 22:25
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Review from claude: comparing against ember-template-lint no-at-ember-render-modifiers

⚠️ Error message recommends the banned pattern?. The PR says: "Use (did-insert), (did-update), or (will-destroy) from ember-render-helpers instead." —The original gives per-modifier messages pointing to custom modifiers:

Do not use the did-insert modifier. This modifier was intended to ease migration to Octane and not for long-term side-effects. Instead, refactor to use a custom modifier. See
https://github.com/ember-modifier/ember-modifier

Fix: replace the message to match the original's guidance, or at least point to ember-modifier instead of recommending the same pattern back? (or is render-helpers ok while render-modifiers not?)

Detection logic and test coverage are otherwise correct. The docs migration section already correctly references ember-modifier — only the lint message is wrong.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-at-ember-render-modifiers branch from f7fda7a to 0f32a67 Compare March 13, 2026 15:56
@NullVoxPopuli NullVoxPopuli merged commit df7e054 into ember-cli:master Mar 13, 2026
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-at-ember-render-modifiers branch March 13, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants