Skip to content

Extract rule: template-no-action-on-submit-button#2453

Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-action-on-submit-button
Mar 13, 2026
Merged

Extract rule: template-no-action-on-submit-button#2453
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-action-on-submit-button

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-action-on-submit-button branch 3 times, most recently from 11335bf to cb69902 Compare March 10, 2026 22:24
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Claude Review: comparing against ember-template-lint no-action-on-submit-button

✅Looks correct. Error message identical, submit-button detection equivalent (including the no-type-defaults-to-submit case), form ancestry walk works, {{on "click"}} and {{action}} detection both match, good test coverage. No issues found.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-action-on-submit-button branch from cb69902 to fecd837 Compare March 12, 2026 22:57
@NullVoxPopuli NullVoxPopuli merged commit c20baf3 into ember-cli:master Mar 13, 2026
11 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-action-on-submit-button branch March 13, 2026 00:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants