Extract rule: template-no-array-prototype-extensions#2421
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Feb 20, 2026
Conversation
kategengler
reviewed
Feb 19, 2026
|
|
||
| This rule disallows using Ember Array prototype extensions in templates: | ||
|
|
||
| - `firstObject` |
Member
There was a problem hiding this comment.
These are gone in 6.0 https://deprecations.emberjs.com/id/deprecate-array-prototype-extensions though I suppose the lint rule could still be helpful to correct old-timer's muscle memory
Contributor
Author
There was a problem hiding this comment.
I think the lint packages tend to try to span a few more majors than is officially supported
Member
There was a problem hiding this comment.
Yeah but they wouldn't have template tag on that version, would they?
Contributor
Author
There was a problem hiding this comment.
template-tag is supported back to 3.28
kategengler
reviewed
Feb 19, 2026
| ## References | ||
|
|
||
| - [Ember Deprecations - Array prototype extensions](https://deprecations.emberjs.com/v3.x/#toc_ember-array-prototype-extensions) | ||
| - [ember-template-lint: no-array-prototype-extensions](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-array-prototype-extensions.md) |
Member
There was a problem hiding this comment.
Should this reference the old thing?
Contributor
Author
There was a problem hiding this comment.
nay -- will update
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-array-prototype-extensions
branch
from
3a4ab65 to
a22f849
Compare
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-array-prototype-extensions
branch
from
a22f849 to
86bf60e
Compare
kategengler
approved these changes
Feb 20, 2026
NullVoxPopuli
deleted the
nvp/template-lint-extract-rule-template-no-array-prototype-extensions
branch
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.