Skip to content

Extract rule: template-no-block-params-for-html-elements#2412

Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-block-params-for-html-elements
Feb 20, 2026
Merged

Extract rule: template-no-block-params-for-html-elements#2412
NullVoxPopuli merged 1 commit intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-block-params-for-html-elements

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

Comment thread lib/rules/template-no-block-params-for-html-elements.js Outdated
@NullVoxPopuli NullVoxPopuli marked this pull request as draft February 18, 2026 00:18
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-block-params-for-html-elements branch 3 times, most recently from 17ac6de to 1307846 Compare February 20, 2026 16:27
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-block-params-for-html-elements branch from 1307846 to e0150b8 Compare February 20, 2026 16:50

ruleTester.run('template-no-block-params-for-html-elements', rule, {
valid: [
`let div = <template>{{yield "hello"}}</template>;
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol, but please don't do this <3

@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review February 20, 2026 16:56
Copy link
Copy Markdown

@driesdl driesdl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this actually happen?

@NullVoxPopuli
Copy link
Copy Markdown
Contributor Author

I think it's more that through linting, we can provide better error and explanation (linking to docs, etc) than the compiler -- even if rare, when it does happen folks are confused, and this lint will help steer towards correctness

@NullVoxPopuli NullVoxPopuli merged commit 32c6a86 into ember-cli:master Feb 20, 2026
10 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-block-params-for-html-elements branch February 20, 2026 21:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants