Extract rule: template-no-block-params-for-html-elements#2412
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Feb 20, 2026
Conversation
NullVoxPopuli
commented
Feb 18, 2026
17ac6de to
1307846
Compare
1307846 to
e0150b8
Compare
NullVoxPopuli
commented
Feb 20, 2026
|
|
||
| ruleTester.run('template-no-block-params-for-html-elements', rule, { | ||
| valid: [ | ||
| `let div = <template>{{yield "hello"}}</template>; |
Contributor
Author
There was a problem hiding this comment.
lol, but please don't do this <3
Contributor
Author
|
I think it's more that through linting, we can provide better error and explanation (linking to docs, etc) than the compiler -- even if rare, when it does happen folks are confused, and this lint will help steer towards correctness |
kategengler
approved these changes
Feb 20, 2026
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.