Skip to content

Extract rule: template-no-bare-strings#2409

Merged
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-bare-strings
Mar 13, 2026
Merged

Extract rule: template-no-bare-strings#2409
NullVoxPopuli merged 2 commits intoember-cli:masterfrom
NullVoxPopuli:nvp/template-lint-extract-rule-template-no-bare-strings

Conversation

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Split from #2371.

@NullVoxPopuli NullVoxPopuli marked this pull request as draft February 18, 2026 00:14
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-strings branch 4 times, most recently from 98f44f1 to 6398c52 Compare February 20, 2026 16:20
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-strings branch 2 times, most recently from 5236620 to a35d6e7 Compare March 6, 2026 23:33
@NullVoxPopuli NullVoxPopuli marked this pull request as ready for review March 6, 2026 23:34
@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-strings branch from a35d6e7 to 519302e Compare March 10, 2026 22:25
@johanrd
Copy link
Copy Markdown
Contributor

johanrd commented Mar 12, 2026

Claude Review: comparing against ember-template-lint no-bare-strings

<Input>/<Textarea> handling differs from original. The original skips BUILTIN_COMPONENT_ATTRIBUTES (Input/Textarea placeholder/@placeholder) in strict mode (gjs/gts) because these names could
refer to custom components named Input and Textarea, not Ember built-ins — preferring false negatives over false positives. The PR always checks them regardless of mode.

This is the only behavioral difference I found. Everything else matches: allowlist (all 67 entries), globalAttributes/elementAttributes defaults, page-title/if/unless/concat helper handling, config
merging for object and array forms, ignored elements, and the GJS <template> wrapper detection.

@NullVoxPopuli NullVoxPopuli force-pushed the nvp/template-lint-extract-rule-template-no-bare-strings branch from 519302e to d284e26 Compare March 13, 2026 19:02
@NullVoxPopuli NullVoxPopuli merged commit 5a482d5 into ember-cli:master Mar 13, 2026
9 checks passed
@NullVoxPopuli NullVoxPopuli deleted the nvp/template-lint-extract-rule-template-no-bare-strings branch March 13, 2026 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants