Extract rule: template-no-attrs-in-components#2407
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Feb 20, 2026
Conversation
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-attrs-in-components
branch
2 times, most recently
from
6bd4adf to
3d210bf
Compare
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-attrs-in-components
branch
from
3d210bf to
0575fa6
Compare
driesdl
approved these changes
Feb 20, 2026
|
|
||
| <!-- end auto-generated rule header --> | ||
|
|
||
| This rule prevents the usage of `this.attrs` property to access values passed to the component. Use `@arg` syntax instead. |
There was a problem hiding this comment.
Should we metion it's also from the octane era?
Contributor
Author
There was a problem hiding this comment.
perhaps -- was attrs ever recommended? even in @ember/components?
Member
There was a problem hiding this comment.
I think it was in docs and it was, at some point, very common.
kategengler
approved these changes
Feb 20, 2026
NullVoxPopuli
deleted the
nvp/template-lint-extract-rule-template-no-attrs-in-components
branch
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.