Extract rule: template-no-arguments-for-html-elements#2403
Merged
NullVoxPopuli merged 1 commit intoember-cli:masterfrom Feb 19, 2026
Conversation
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-arguments-for-html-elements
branch
from
6512430 to
b01777a
Compare
kategengler
reviewed
Feb 19, 2026
NullVoxPopuli
commented
Feb 19, 2026
kategengler
reviewed
Feb 19, 2026
| 'ul', | ||
| 'var', | ||
| 'video', | ||
| 'wbr', |
Member
There was a problem hiding this comment.
The existing implementation didn't rely upon a list of html elements https://github.com/ember-template-lint/ember-template-lint/blob/main/lib/rules/no-arguments-for-html-elements.js
do we want to?
Contributor
Author
There was a problem hiding this comment.
I think so, because we can do:
<Foo as |foo|>
<foo @hello="greetings" />
</Foo>
Member
There was a problem hiding this comment.
The previous implementation supported that as well. A dep seems reasonable
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-arguments-for-html-elements
branch
from
852388c to
54e72ab
Compare
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-arguments-for-html-elements
branch
from
54e72ab to
f0209b2
Compare
NullVoxPopuli
commented
Feb 19, 2026
| `let div = <template>{{@greeting}}</template> | ||
|
|
||
| <template> | ||
| <div @greeting="hello" /> |
Contributor
Author
There was a problem hiding this comment.
while super goofy, is very important that this is allowed
kategengler
approved these changes
Feb 19, 2026
NullVoxPopuli
deleted the
nvp/template-lint-extract-rule-template-no-arguments-for-html-elements
branch
This was referenced Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.