Extract rule: template-no-action-on-submit-button#2400
Closed
NullVoxPopuli wants to merge 1 commit intoember-cli:masterfrom
Closed
Conversation
NullVoxPopuli
force-pushed
the
nvp/template-lint-extract-rule-template-no-action-on-submit-button
branch
from
b8a1af1 to
abb3e7c
Compare
kategengler
reviewed
Feb 19, 2026
|
|
||
| ## Rule Details | ||
|
|
||
| This rule disallows using the `action` attribute on `<button>` elements (which default to type="submit") and `<input type="submit">` elements. |
Member
There was a problem hiding this comment.
Is this relevant? I can find no mention of action as an attribute to button or input so I believe this is reference to some esoteric way of triggering actions in Ember?
Contributor
Author
There was a problem hiding this comment.
yea, I think we can just kill this rule
NullVoxPopuli
deleted the
nvp/template-lint-extract-rule-template-no-action-on-submit-button
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #2371.