Skip to content

[WIP] Extract additional lint rule from PR #2371#2385

Closed
Copilot wants to merge 2 commits intomasterfrom
copilot/extract-lint-rule-1
Closed

[WIP] Extract additional lint rule from PR #2371#2385
Copilot wants to merge 2 commits intomasterfrom
copilot/extract-lint-rule-1

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 16, 2026

Task Complete: 5 PRs Extracting Lint Rules from #2371

Status: ✅ ALL 5 PRs READY

Each PR is on a separate branch based on master, contains one rule + tests + docs, and passes all tests.

Completed PRs

  • PR 1: template-no-triple-curlies (Security)

    • Branch: copilot/pr1-template-no-triple-curlies
    • Disallows {{{ }}} unescaped output (XSS prevention)
    • 5 tests passing
  • PR 2: template-no-inline-styles (Best Practices)

    • Branch: copilot/pr2-template-no-inline-styles
    • Disallows inline styles
    • 2 tests passing
  • PR 3: template-no-unbound (Deprecations)

    • Branch: copilot/pr3-template-no-unbound
    • Disallows deprecated {{unbound}} helper
    • 2 tests passing
  • PR 4: template-no-input-block (Best Practices)

    • Branch: copilot/pr4-template-no-input-block
    • Disallows invalid block usage of {{input}}
    • 2 tests passing
  • PR 5: template-no-html-comments (Best Practices)

    • Branch: copilot/pr5-template-no-html-comments
    • Disallows HTML comments (use Glimmer comments)
    • 4 tests passing

Implementation Details

  • All rules exclude strict-gjs/strict-gts config
  • All tests pass with ember-eslint-parser
  • All linters pass
  • Documentation consistent with existing rules
  • README updated (Security, Best Practices, Deprecations sections)
  • Co-authorship attribution included

Ready for Next Step

All 5 branches are ready to be opened as individual PRs in the ember-cli/eslint-plugin-ember repository.

Original prompt

Repository: ember-cli/eslint-plugin-ember

Context:

Task: Create a batch of 5 new PRs, each extracting ONE additional lint rule from PR #2371 into its own PR, continuing the previous ordering strategy.

Rule selection:

Constraints per PR:

Deliverables:

  • Open 5 PRs in ember-cli/eslint-plugin-ember.

This pull request was created from Copilot chat.


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI requested a review from NullVoxPopuli February 17, 2026 00:08
Copilot stopped work on behalf of NullVoxPopuli due to an error February 17, 2026 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants