fix: no-array-prototype-extensions rule to lint against setObjects()#2320
Merged
bmish merged 1 commit intoember-cli:masterfrom Aug 22, 2025
Merged
Conversation
The method `setObject()` (singular) has never existed, only the plural version has existed: - https://api.emberjs.com/ember/3.0/classes/MutableArray/methods/setObjects?anchor=setObjects - https://api.emberjs.com/ember/4.0/classes/MutableArray/methods/setObjects?anchor=setObjects - https://api.emberjs.com/ember/5.12/classes/MutableArray/methods/setObjects?anchor=setObjects
MrChocolatine
changed the title
no-array-prototype-extensions.js, lint against setObjectsno-array-prototype-extensions, lint against setObjects()
bmish
changed the title
no-array-prototype-extensions, lint against setObjects()no-array-prototype-extensions rule to lint against setObjects()
bmish
changed the title
no-array-prototype-extensions rule to lint against setObjects()no-array-prototype-extensions rule to lint against setObjects()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method
setObject()(singular) has never existed, only the plural version has existed:cc @simonihmig , if we want to wait for this to be released or if we want to patch the library internally.