Merge pull request #2646 from johanrd/autofix/no-positional-data-test-selectors

Post-merge-review: Restore autofix for template-no-positional-data-test-selectors

Author: NullVoxPopuli

README.md

@@ -256,7 +256,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [template-no-outlet-outside-routes](docs/rules/template-no-outlet-outside-routes.md)                               | disallow {{outlet}} outside of route templates                               |    |    |    |
 | [template-no-page-title-component](docs/rules/template-no-page-title-component.md)                                 | disallow usage of ember-page-title component                                 |    |    |    |
 | [template-no-passed-in-event-handlers](docs/rules/template-no-passed-in-event-handlers.md)                         | disallow passing event handlers directly as component arguments              |    |    |    |
-| [template-no-positional-data-test-selectors](docs/rules/template-no-positional-data-test-selectors.md)             | disallow positional data-test-* params in curly invocations                  |    |    |    |
+| [template-no-positional-data-test-selectors](docs/rules/template-no-positional-data-test-selectors.md)             | disallow positional data-test-* params in curly invocations                  |    | 🔧 |    |
 | [template-no-potential-path-strings](docs/rules/template-no-potential-path-strings.md)                             | disallow potential path strings in attribute values                          |    |    |    |
 | [template-no-redundant-fn](docs/rules/template-no-redundant-fn.md)                                                 | disallow unnecessary usage of (fn) helper                                    |    | 🔧 |    |
 | [template-no-restricted-invocations](docs/rules/template-no-restricted-invocations.md)                             | disallow certain components, helpers or modifiers from being used            |    |    |    |

docs/rules/template-no-positional-data-test-selectors.md

@@ -1,5 +1,7 @@
 # ember/template-no-positional-data-test-selectors
 
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
 <!-- end auto-generated rule header -->
 
 ## Motivation

lib/rules/template-no-positional-data-test-selectors.js

@@ -50,6 +50,13 @@ function checkNode(node, context) {
       context.report({
         node,
         messageId: 'noPositionalDataTest',
+        fix(fixer) {
+          // Convert the positional param to a hash pair by appending =true.
+          // e.g. `data-test-foo` becomes `data-test-foo=true`
+          const sourceCode = context.sourceCode;
+          const paramText = sourceCode.getText(param);
+          return fixer.replaceText(param, `${paramText}=true`);
+        },
       });
       return;
     }
@@ -66,7 +73,7 @@ module.exports = {
       url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-positional-data-test-selectors.md',
       templateMode: 'both',
     },
-    fixable: null,
+    fixable: 'code',
     schema: [],
     messages: {
       noPositionalDataTest:

tests/lib/rules/template-no-positional-data-test-selectors.js

@@ -78,7 +78,13 @@ ruleTester.run('template-no-positional-data-test-selectors', rule, {
           degreeA11yText=(t "i18n_distance_a11y_v2" distance=recipientDistance)
         }}
       </template>`,
-      output: null,
+      output: `<template>
+        {{badge
+          data-test-profile-card-one-to-one-connection-distance=true
+          degreeText=(t "i18n_distance_v2" distance=recipientDistance)
+          degreeA11yText=(t "i18n_distance_a11y_v2" distance=recipientDistance)
+        }}
+      </template>`,
       errors: [
         {
           message:
@@ -160,7 +166,13 @@ hbsRuleTester.run('template-no-positional-data-test-selectors', rule, {
           degreeA11yText=(t "i18n_distance_a11y_v2" distance=recipientDistance)
         }}
       `,
-      output: null,
+      output: `
+        {{badge
+          data-test-profile-card-one-to-one-connection-distance=true
+          degreeText=(t "i18n_distance_v2" distance=recipientDistance)
+          degreeA11yText=(t "i18n_distance_a11y_v2" distance=recipientDistance)
+        }}
+      `,
       errors: [
         {
           message: