Merge pull request #2681 from johanrd/false_positive/template-no-whitespace-for-layout

Post-merge-review: Fix template-no-whitespace-for-layout false positive on attribute values

Author: NullVoxPopuli

lib/rules/template-no-whitespace-for-layout.js

@@ -27,6 +27,14 @@ module.exports = {
 
     return {
       GlimmerTextNode(node) {
+        // Only flag body text, not attribute values. ember-eslint-parser
+        // emits attribute values as GlimmerTextNode children of a
+        // GlimmerAttrNode; skip those so only element body whitespace is
+        // checked.
+        if (node.parent?.type === 'GlimmerAttrNode') {
+          return;
+        }
+
         const text = sourceCode.getText(node);
         if (!text) {
           return;

tests/lib/rules/template-no-whitespace-for-layout.js

@@ -18,6 +18,10 @@ const validHbs = [
 >
   example
 </div>`,
+  // Attribute values with consecutive spaces must not be flagged (false positive,
+  // cf. ember-template-lint#2899) — the rule targets element body text only.
+  '<div class="foo  bar"></div>',
+  '<div style="margin: 0;  padding: 0"></div>',
 ];
 
 const invalidHbs = [