Merge pull request #2693 from johanrd/day_fix/template-no-negated-comparison

Post-merge-review: template-no-negated-comparison: document name-clash; drop non-standard 'ne'

Author: NullVoxPopuli

docs/rules/template-no-negated-comparison.md

@@ -6,7 +6,7 @@ Disallows negated comparison operators in templates.
 
 ## Rule Details
 
-Use positive comparison operators with `{{unless}}` instead of negated comparison operators like `not-eq` or `ne`.
+Use positive comparison operators with `{{unless}}` instead of negated comparison operators like `not-eq`.
 
 ## Examples
 
@@ -20,14 +20,6 @@ Examples of **incorrect** code for this rule:
 </template>
 ```
 
-```gjs
-<template>
-  {{#if (ne this.a this.b)}}
-    Not equal
-  {{/if}}
-</template>
-```
-
 Examples of **correct** code for this rule:
 
 ```gjs
@@ -45,7 +37,3 @@ Examples of **correct** code for this rule:
   {{/if}}
 </template>
 ```
-
-## References
-
-- [eslint-plugin-ember template-no-negated-condition](https://github.com/ember-cli/eslint-plugin-ember/blob/master/docs/rules/template-no-negated-condition.md)

lib/rules/template-no-negated-comparison.js

@@ -21,7 +21,7 @@ module.exports = {
         if (
           node.path &&
           node.path.type === 'GlimmerPathExpression' &&
-          (node.path.original === 'not-eq' || node.path.original === 'ne')
+          node.path.original === 'not-eq'
         ) {
           context.report({
             node,

tests/lib/rules/template-no-negated-comparison.js

@@ -29,6 +29,12 @@ ruleTester.run('template-no-negated-comparison', rule, {
     `<template>
       <div></div>
     </template>`,
+    // `ne` is not a standard Ember/ember-truth-helpers helper; the rule must not flag it.
+    `<template>
+      {{#if (ne this.a this.b)}}
+        Not equal
+      {{/if}}
+    </template>`,
   ],
 
   invalid: [
@@ -46,20 +52,6 @@ ruleTester.run('template-no-negated-comparison', rule, {
         },
       ],
     },
-    {
-      code: `<template>
-        {{#if (ne this.a this.b)}}
-          Not equal
-        {{/if}}
-      </template>`,
-      output: null,
-      errors: [
-        {
-          message: 'Use positive comparison operators instead of negated ones.',
-          type: 'GlimmerSubExpression',
-        },
-      ],
-    },
     {
       code: `<template>
         <div class={{if (not-eq this.state "active") "inactive"}}></div>