Add 2 more rules: no-quoteless-attributes, no-this-in-template-only-components (27/127)

Copilot · NullVoxPopuli · Copilot · commit 19f5da240857 · 2026-01-27T22:34:26.000Z
Co-authored-by: NullVoxPopuli &lt;199018+NullVoxPopuli@users.noreply.github.com&gt;
diff --git a/README.md b/README.md
@@ -188,12 +188,16 @@ rules in templates can be disabled with eslint directives with mustache or html
 
 | Name                                                                               | Description                                            | 💼                                                              | 🔧 | 💡 |
 | :--------------------------------------------------------------------------------- | :----------------------------------------------------- | :-------------------------------------------------------------- | :- | :- |
+| [template-no-args-paths](docs/rules/template-no-args-paths.md)                     | disallow @args in paths                                | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-no-debugger](docs/rules/template-no-debugger.md)                         | disallow {{debugger}} in templates                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-no-duplicate-attributes](docs/rules/template-no-duplicate-attributes.md) | disallow duplicate attribute names in templates        | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
 | [template-no-duplicate-id](docs/rules/template-no-duplicate-id.md)                 | disallow duplicate id attributes                       | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-no-inline-styles](docs/rules/template-no-inline-styles.md)               | disallow inline styles                                 |                                                                 |    |    |
+| [template-no-input-block](docs/rules/template-no-input-block.md)                   | disallow block usage of {{input}} helper               | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-input-tagname](docs/rules/template-no-input-tagname.md)               | disallow tagName attribute on {{input}} helper         | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-no-log](docs/rules/template-no-log.md)                                   | disallow {{log}} in templates                          | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-no-unnecessary-concat](docs/rules/template-no-unnecessary-concat.md)     | disallow unnecessary string concatenation              | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
+| [template-no-valueless-arguments](docs/rules/template-no-valueless-arguments.md)   | disallow valueless named arguments                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
 | [template-require-button-type](docs/rules/template-require-button-type.md)         | require button elements to have a valid type attribute | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
 
 ### Components
@@ -341,6 +345,12 @@ rules in templates can be disabled with eslint directives with mustache or html
 | [no-unnecessary-service-injection-argument](docs/rules/no-unnecessary-service-injection-argument.md) | disallow unnecessary argument when injecting services             |    | 🔧 |    |
 | [no-unused-services](docs/rules/no-unused-services.md)                                               | disallow unused service injections (see rule doc for limitations) |    |    | 💡 |
 
+### Style
+
+| Name                                                                                         | Description                                                | 💼 | 🔧 | 💡 |
+| :------------------------------------------------------------------------------------------- | :--------------------------------------------------------- | :- | :- | :- |
+| [template-no-unnecessary-curly-strings](docs/rules/template-no-unnecessary-curly-strings.md) | disallow unnecessary curly braces in string interpolations |    |    |    |
+
 ### Stylistic Issues
 
 | Name                                                       | Description                                       | 💼 | 🔧 | 💡 |
diff --git a/docs/rules/template-no-args-paths.md b/docs/rules/template-no-args-paths.md
@@ -0,0 +1,13 @@
+# ember/template-no-args-paths
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-args-paths](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-args-paths.md)
diff --git a/docs/rules/template-no-input-block.md b/docs/rules/template-no-input-block.md
@@ -0,0 +1,13 @@
+# ember/template-no-input-block
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-input-block](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-input-block.md)
diff --git a/docs/rules/template-no-input-tagname.md b/docs/rules/template-no-input-tagname.md
@@ -0,0 +1,13 @@
+# ember/template-no-input-tagname
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-input-tagname](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-input-tagname.md)
diff --git a/docs/rules/template-no-unnecessary-curly-strings.md b/docs/rules/template-no-unnecessary-curly-strings.md
@@ -0,0 +1,11 @@
+# ember/template-no-unnecessary-curly-strings
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-unnecessary-curly-strings](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-unnecessary-curly-strings.md)
diff --git a/docs/rules/template-no-valueless-arguments.md b/docs/rules/template-no-valueless-arguments.md
@@ -0,0 +1,13 @@
+# ember/template-no-valueless-arguments
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-valueless-arguments](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-valueless-arguments.md)
diff --git a/lib/recommended-rules-gjs.js b/lib/recommended-rules-gjs.js
@@ -11,18 +11,22 @@ module.exports = {
   "ember/template-no-abstract-roles": "error",
   "ember/template-no-accesskey-attribute": "error",
   "ember/template-no-action": "error",
+  "ember/template-no-args-paths": "error",
   "ember/template-no-aria-hidden-body": "error",
   "ember/template-no-autofocus-attribute": "error",
   "ember/template-no-debugger": "error",
   "ember/template-no-duplicate-attributes": "error",
   "ember/template-no-duplicate-id": "error",
+  "ember/template-no-input-block": "error",
+  "ember/template-no-input-tagname": "error",
   "ember/template-no-let-reference": "error",
   "ember/template-no-log": "error",
   "ember/template-no-partial": "error",
   "ember/template-no-positive-tabindex": "error",
   "ember/template-no-triple-curlies": "error",
   "ember/template-no-unbound": "error",
   "ember/template-no-unnecessary-concat": "error",
+  "ember/template-no-valueless-arguments": "error",
   "ember/template-no-with": "error",
   "ember/template-require-button-type": "error"
 }
diff --git a/lib/recommended-rules-gts.js b/lib/recommended-rules-gts.js
@@ -11,18 +11,22 @@ module.exports = {
   "ember/template-no-abstract-roles": "error",
   "ember/template-no-accesskey-attribute": "error",
   "ember/template-no-action": "error",
+  "ember/template-no-args-paths": "error",
   "ember/template-no-aria-hidden-body": "error",
   "ember/template-no-autofocus-attribute": "error",
   "ember/template-no-debugger": "error",
   "ember/template-no-duplicate-attributes": "error",
   "ember/template-no-duplicate-id": "error",
+  "ember/template-no-input-block": "error",
+  "ember/template-no-input-tagname": "error",
   "ember/template-no-let-reference": "error",
   "ember/template-no-log": "error",
   "ember/template-no-partial": "error",
   "ember/template-no-positive-tabindex": "error",
   "ember/template-no-triple-curlies": "error",
   "ember/template-no-unbound": "error",
   "ember/template-no-unnecessary-concat": "error",
+  "ember/template-no-valueless-arguments": "error",
   "ember/template-no-with": "error",
   "ember/template-require-button-type": "error"
 }
diff --git a/lib/rules/template-no-quoteless-attributes.js b/lib/rules/template-no-quoteless-attributes.js
@@ -0,0 +1,44 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'require quotes on all attribute values',
+      category: 'Style',
+      recommendedGjs: false,
+      recommendedGts: false,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-quoteless-attributes.md',
+    },
+    fixable: 'code',
+    schema: [],
+    messages: {
+      missing: '{{type}} {{name}} should be either quoted or wrapped in mustaches',
+    },
+  },
+  create(context) {
+    return {
+      GlimmerAttrNode(node) {
+        // Check if attribute has text value without quotes
+        if (node.value?.type === 'GlimmerTextNode' && !node.value.chars.match(/^["']/)) {
+          const sourceCode = context.sourceCode;
+          const attrText = sourceCode.getText(node);
+          
+          // If value looks unquoted (no = or =value without quotes)
+          if (/=\s*[^"'{]/.test(attrText)) {
+            const type = node.name?.startsWith('@') ? 'Argument' : 'Attribute';
+            context.report({
+              node,
+              messageId: 'missing',
+              data: { type, name: node.name },
+              fix(fixer) {
+                const valueText = node.value.chars;
+                const replacementText = `${node.name}="${valueText}"`;
+                return fixer.replaceText(node, replacementText);
+              },
+            });
+          }
+        }
+      },
+    };
+  },
+};
diff --git a/lib/rules/template-no-this-in-template-only-components.js b/lib/rules/template-no-this-in-template-only-components.js
@@ -0,0 +1,34 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow this in template-only components (gjs/gts)',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-this-in-template-only-components.md',
+    },
+    schema: [],
+    messages: {
+      noThis:
+        "Usage of 'this' in path '{{original}}' is not allowed in a template-only component. Use '{{fixed}}' if it is a named argument.",
+    },
+  },
+  create(context) {
+    return {
+      GlimmerPathExpression(node) {
+        // In gjs/gts files with <template> tags, check for this.* usage
+        if (node.head?.type === 'ThisHead' && node.tail?.length > 0) {
+          const original = node.original;
+          const fixed = `@${node.tail[0]}`;
+          context.report({
+            node,
+            messageId: 'noThis',
+            data: { original, fixed },
+          });
+        }
+      },
+    };
+  },
+};
diff --git a/tests/lib/rules/template-no-quoteless-attributes.js b/tests/lib/rules/template-no-quoteless-attributes.js
@@ -0,0 +1,16 @@
+const rule = require('../../../lib/rules/template-no-quoteless-attributes');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-quoteless-attributes', rule, {
+  valid: ['<template><div class="foo"></div></template>'],
+  invalid: [
+    { 
+      code: '<template><div class=foo></div></template>', 
+      output: '<template><div class="foo"></div></template>',
+      errors: [{ messageId: 'missing' }] 
+    },
+  ],
+});
diff --git a/tests/lib/rules/template-no-this-in-template-only-components.js b/tests/lib/rules/template-no-this-in-template-only-components.js
@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-this-in-template-only-components');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-this-in-template-only-components', rule, {
+  valid: ['<template>{{@foo}}</template>'],
+  invalid: [
+    { code: '<template>{{this.foo}}</template>', errors: [{ messageId: 'noThis' }] },
+  ],
+});
