Add 5 more rules: no-input-block, no-input-tagname, no-valueless-arguments, no-args-paths, no-unnecessary-curly-strings (25/127 total)

Co-authored-by: NullVoxPopuli <[email protected]>

Author: Copilot

lib/rules/template-no-args-paths.js

@@ -0,0 +1,24 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow @args in paths',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-args-paths.md',
+    },
+    schema: [],
+    messages: { argsPath: 'Do not use paths with @args, use @argName directly instead.' },
+  },
+  create(context) {
+    return {
+      GlimmerPathExpression(node) {
+        if (node.original?.startsWith('@args.')) {
+          context.report({ node, messageId: 'argsPath' });
+        }
+      },
+    };
+  },
+};

lib/rules/template-no-input-block.js

@@ -0,0 +1,24 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow block usage of {{input}} helper',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-input-block.md',
+    },
+    schema: [],
+    messages: { blockUsage: 'Unexpected block usage. The input helper may only be used inline.' },
+  },
+  create(context) {
+    return {
+      GlimmerBlockStatement(node) {
+        if (node.path?.type === 'GlimmerPathExpression' && node.path.original === 'input') {
+          context.report({ node, messageId: 'blockUsage' });
+        }
+      },
+    };
+  },
+};

lib/rules/template-no-input-tagname.js

@@ -0,0 +1,36 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow tagName attribute on {{input}} helper',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-input-tagname.md',
+    },
+    schema: [],
+    messages: { unexpected: 'Unexpected tagName usage on input helper.' },
+  },
+  create(context) {
+    function check(node) {
+      if (!node.path) return;
+      const attrs = node.hash?.pairs || [];
+      const hasTagName = attrs.some((a) => a.key === 'tagName');
+      
+      if (node.path.original === 'input' && hasTagName) {
+        context.report({ node, messageId: 'unexpected' });
+      } else if (
+        node.path.original === 'component' &&
+        node.params?.[0]?.original === 'input' &&
+        hasTagName
+      ) {
+        context.report({ node, messageId: 'unexpected' });
+      }
+    }
+    return {
+      GlimmerMustacheStatement: check,
+      GlimmerSubExpression: check,
+    };
+  },
+};

lib/rules/template-no-unnecessary-curly-strings.js

@@ -0,0 +1,27 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow unnecessary curly braces in string interpolations',
+      category: 'Style',
+      recommendedGjs: false,
+      recommendedGts: false,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-unnecessary-curly-strings.md',
+    },
+    schema: [],
+    messages: { unnecessary: 'Unnecessary curly braces in string.' },
+  },
+  create(context) {
+    return {
+      GlimmerAttrNode(node) {
+        if (
+          node.value?.type === 'GlimmerMustacheStatement' &&
+          node.value.path?.type === 'GlimmerStringLiteral'
+        ) {
+          context.report({ node: node.value, messageId: 'unnecessary' });
+        }
+      },
+    };
+  },
+};

lib/rules/template-no-valueless-arguments.js

@@ -0,0 +1,25 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'problem',
+    docs: {
+      description: 'disallow valueless named arguments',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-valueless-arguments.md',
+    },
+    schema: [],
+    messages: { valueless: 'Named arguments should have an explicitly assigned value.' },
+  },
+  create(context) {
+    return {
+      GlimmerAttrNode(node) {
+        // Check if it's a named argument (@foo) with no value
+        if (node.name?.startsWith('@') && (!node.value || node.value.type === 'GlimmerTextNode' && !node.value.chars)) {
+          context.report({ node, messageId: 'valueless' });
+        }
+      },
+    };
+  },
+};

tests/lib/rules/template-no-args-paths.js

@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-args-paths');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-args-paths', rule, {
+  valid: ['<template>{{@foo}}</template>'],
+  invalid: [
+    { code: '<template>{{@args.foo}}</template>', errors: [{ messageId: 'argsPath' }] },
+  ],
+});

tests/lib/rules/template-no-input-block.js

@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-input-block');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-input-block', rule, {
+  valid: ['<template>{{input value=this.foo}}</template>'],
+  invalid: [
+    { code: '<template>{{#input}}{{/input}}</template>', errors: [{ messageId: 'blockUsage' }] },
+  ],
+});

tests/lib/rules/template-no-input-tagname.js

@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-input-tagname');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-input-tagname', rule, {
+  valid: ['<template>{{input value=this.foo}}</template>'],
+  invalid: [
+    { code: '<template>{{input tagName="span"}}</template>', errors: [{ messageId: 'unexpected' }] },
+  ],
+});

tests/lib/rules/template-no-unnecessary-curly-strings.js

@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-unnecessary-curly-strings');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-unnecessary-curly-strings', rule, {
+  valid: ['<template><div class="foo"></div></template>'],
+  invalid: [
+    { code: '<template><div class={{"foo"}}></div></template>', errors: [{ messageId: 'unnecessary' }] },
+  ],
+});

tests/lib/rules/template-no-valueless-arguments.js

@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-valueless-arguments');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-valueless-arguments', rule, {
+  valid: ['<template><Foo @bar={{true}} /></template>'],
+  invalid: [
+    { code: '<template><Foo @bar /></template>', errors: [{ messageId: 'valueless' }] },
+  ],
+});