Add 2 more rules: no-forbidden-elements, no-obsolete-elements (29/127)

Copilot · NullVoxPopuli · Copilot · commit 08c4356d4427 · 2026-01-27T22:35:41.000Z
Co-authored-by: NullVoxPopuli &lt;199018+NullVoxPopuli@users.noreply.github.com&gt;
diff --git a/README.md b/README.md
@@ -186,19 +186,22 @@ rules in templates can be disabled with eslint directives with mustache or html
 
 ### Best Practices
 
-| Name                                                                               | Description                                            | 💼                                                              | 🔧 | 💡 |
-| :--------------------------------------------------------------------------------- | :----------------------------------------------------- | :-------------------------------------------------------------- | :- | :- |
-| [template-no-args-paths](docs/rules/template-no-args-paths.md)                     | disallow @args in paths                                | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-debugger](docs/rules/template-no-debugger.md)                         | disallow {{debugger}} in templates                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-duplicate-attributes](docs/rules/template-no-duplicate-attributes.md) | disallow duplicate attribute names in templates        | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
-| [template-no-duplicate-id](docs/rules/template-no-duplicate-id.md)                 | disallow duplicate id attributes                       | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-inline-styles](docs/rules/template-no-inline-styles.md)               | disallow inline styles                                 |                                                                 |    |    |
-| [template-no-input-block](docs/rules/template-no-input-block.md)                   | disallow block usage of {{input}} helper               | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-input-tagname](docs/rules/template-no-input-tagname.md)               | disallow tagName attribute on {{input}} helper         | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-log](docs/rules/template-no-log.md)                                   | disallow {{log}} in templates                          | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-no-unnecessary-concat](docs/rules/template-no-unnecessary-concat.md)     | disallow unnecessary string concatenation              | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
-| [template-no-valueless-arguments](docs/rules/template-no-valueless-arguments.md)   | disallow valueless named arguments                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
-| [template-require-button-type](docs/rules/template-require-button-type.md)         | require button elements to have a valid type attribute | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
+| Name                                                                                                       | Description                                            | 💼                                                              | 🔧 | 💡 |
+| :--------------------------------------------------------------------------------------------------------- | :----------------------------------------------------- | :-------------------------------------------------------------- | :- | :- |
+| [template-no-args-paths](docs/rules/template-no-args-paths.md)                                             | disallow @args in paths                                | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-debugger](docs/rules/template-no-debugger.md)                                                 | disallow {{debugger}} in templates                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-duplicate-attributes](docs/rules/template-no-duplicate-attributes.md)                         | disallow duplicate attribute names in templates        | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
+| [template-no-duplicate-id](docs/rules/template-no-duplicate-id.md)                                         | disallow duplicate id attributes                       | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-forbidden-elements](docs/rules/template-no-forbidden-elements.md)                             | disallow specific HTML elements                        |                                                                 |    |    |
+| [template-no-inline-styles](docs/rules/template-no-inline-styles.md)                                       | disallow inline styles                                 |                                                                 |    |    |
+| [template-no-input-block](docs/rules/template-no-input-block.md)                                           | disallow block usage of {{input}} helper               | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-input-tagname](docs/rules/template-no-input-tagname.md)                                       | disallow tagName attribute on {{input}} helper         | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-log](docs/rules/template-no-log.md)                                                           | disallow {{log}} in templates                          | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-obsolete-elements](docs/rules/template-no-obsolete-elements.md)                               | disallow obsolete HTML elements                        | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-this-in-template-only-components](docs/rules/template-no-this-in-template-only-components.md) | disallow this in template-only components (gjs/gts)    | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-no-unnecessary-concat](docs/rules/template-no-unnecessary-concat.md)                             | disallow unnecessary string concatenation              | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
+| [template-no-valueless-arguments](docs/rules/template-no-valueless-arguments.md)                           | disallow valueless named arguments                     | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) |    |    |
+| [template-require-button-type](docs/rules/template-require-button-type.md)                                 | require button elements to have a valid type attribute | ![gjs logo](/docs/svgs/gjs.svg) ![gts logo](/docs/svgs/gts.svg) | 🔧 |    |
 
 ### Components
 
@@ -349,6 +352,7 @@ rules in templates can be disabled with eslint directives with mustache or html
 
 | Name                                                                                         | Description                                                | 💼 | 🔧 | 💡 |
 | :------------------------------------------------------------------------------------------- | :--------------------------------------------------------- | :- | :- | :- |
+| [template-no-quoteless-attributes](docs/rules/template-no-quoteless-attributes.md)           | require quotes on all attribute values                     |    | 🔧 |    |
 | [template-no-unnecessary-curly-strings](docs/rules/template-no-unnecessary-curly-strings.md) | disallow unnecessary curly braces in string interpolations |    |    |    |
 
 ### Stylistic Issues
diff --git a/docs/rules/template-no-forbidden-elements.md b/docs/rules/template-no-forbidden-elements.md
@@ -0,0 +1,11 @@
+# ember/template-no-forbidden-elements
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-forbidden-elements](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-forbidden-elements.md)
diff --git a/docs/rules/template-no-obsolete-elements.md b/docs/rules/template-no-obsolete-elements.md
@@ -0,0 +1,13 @@
+# ember/template-no-obsolete-elements
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-obsolete-elements](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-obsolete-elements.md)
diff --git a/docs/rules/template-no-quoteless-attributes.md b/docs/rules/template-no-quoteless-attributes.md
@@ -0,0 +1,13 @@
+# ember/template-no-quoteless-attributes
+
+🔧 This rule is automatically fixable by the [`--fix` CLI option](https://eslint.org/docs/latest/user-guide/command-line-interface#--fix).
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-quoteless-attributes](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-quoteless-attributes.md)
diff --git a/docs/rules/template-no-this-in-template-only-components.md b/docs/rules/template-no-this-in-template-only-components.md
@@ -0,0 +1,13 @@
+# ember/template-no-this-in-template-only-components
+
+💼 This rule is enabled in the following [configs](https://github.com/ember-cli/eslint-plugin-ember#-configurations): ![gjs logo](/docs/svgs/gjs.svg) `recommended-gjs`, ![gts logo](/docs/svgs/gts.svg) `recommended-gts`.
+
+<!-- end auto-generated rule header -->
+
+## Examples
+
+See ember-template-lint documentation.
+
+## References
+
+- [ember-template-lint no-this-in-template-only-components](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-this-in-template-only-components.md)
diff --git a/lib/recommended-rules-gjs.js b/lib/recommended-rules-gjs.js
@@ -21,8 +21,10 @@ module.exports = {
   "ember/template-no-input-tagname": "error",
   "ember/template-no-let-reference": "error",
   "ember/template-no-log": "error",
+  "ember/template-no-obsolete-elements": "error",
   "ember/template-no-partial": "error",
   "ember/template-no-positive-tabindex": "error",
+  "ember/template-no-this-in-template-only-components": "error",
   "ember/template-no-triple-curlies": "error",
   "ember/template-no-unbound": "error",
   "ember/template-no-unnecessary-concat": "error",
diff --git a/lib/recommended-rules-gts.js b/lib/recommended-rules-gts.js
@@ -21,8 +21,10 @@ module.exports = {
   "ember/template-no-input-tagname": "error",
   "ember/template-no-let-reference": "error",
   "ember/template-no-log": "error",
+  "ember/template-no-obsolete-elements": "error",
   "ember/template-no-partial": "error",
   "ember/template-no-positive-tabindex": "error",
+  "ember/template-no-this-in-template-only-components": "error",
   "ember/template-no-triple-curlies": "error",
   "ember/template-no-unbound": "error",
   "ember/template-no-unnecessary-concat": "error",
diff --git a/lib/rules/template-no-forbidden-elements.js b/lib/rules/template-no-forbidden-elements.js
@@ -0,0 +1,25 @@
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow specific HTML elements',
+      category: 'Best Practices',
+      recommendedGjs: false,
+      recommendedGts: false,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-forbidden-elements.md',
+    },
+    schema: [{ type: 'array', items: { type: 'string' } }],
+    messages: { forbidden: 'Use of forbidden element <{{element}}>' },
+  },
+  create(context) {
+    const forbidden = new Set(context.options[0] || []);
+    return {
+      GlimmerElementNode(node) {
+        if (forbidden.has(node.tag)) {
+          context.report({ node, messageId: 'forbidden', data: { element: node.tag } });
+        }
+      },
+    };
+  },
+};
diff --git a/lib/rules/template-no-obsolete-elements.js b/lib/rules/template-no-obsolete-elements.js
@@ -0,0 +1,26 @@
+const OBSOLETE = ['acronym', 'applet', 'basefont', 'bgsound', 'big', 'blink', 'center', 'dir', 'font', 'frame', 'frameset', 'isindex', 'keygen', 'listing', 'marquee', 'menuitem', 'multicol', 'nextid', 'nobr', 'noembed', 'noframes', 'plaintext', 's', 'spacer', 'strike', 'tt', 'u', 'xmp'];
+/** @type {import('eslint').Rule.RuleModule} */
+module.exports = {
+  meta: {
+    type: 'suggestion',
+    docs: {
+      description: 'disallow obsolete HTML elements',
+      category: 'Best Practices',
+      recommendedGjs: true,
+      recommendedGts: true,
+      url: 'https://github.com/ember-cli/eslint-plugin-ember/tree/master/docs/rules/template-no-obsolete-elements.md',
+    },
+    schema: [],
+    messages: { obsolete: '<{{element}}> is obsolete, use modern alternatives' },
+  },
+  create(context) {
+    const obsolete = new Set(OBSOLETE);
+    return {
+      GlimmerElementNode(node) {
+        if (obsolete.has(node.tag)) {
+          context.report({ node, messageId: 'obsolete', data: { element: node.tag } });
+        }
+      },
+    };
+  },
+};
diff --git a/tests/lib/rules/template-no-forbidden-elements.js b/tests/lib/rules/template-no-forbidden-elements.js
@@ -0,0 +1,14 @@
+const rule = require('../../../lib/rules/template-no-forbidden-elements');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-forbidden-elements', rule, {
+  valid: [
+    { code: '<template><div></div></template>', options: [['script']] },
+  ],
+  invalid: [
+    { code: '<template><script></script></template>', options: [['script']], errors: [{ messageId: 'forbidden' }] },
+  ],
+});
diff --git a/tests/lib/rules/template-no-obsolete-elements.js b/tests/lib/rules/template-no-obsolete-elements.js
@@ -0,0 +1,12 @@
+const rule = require('../../../lib/rules/template-no-obsolete-elements');
+const RuleTester = require('eslint').RuleTester;
+const ruleTester = new RuleTester({
+  parser: require.resolve('ember-eslint-parser'),
+  parserOptions: { ecmaVersion: 2022, sourceType: 'module' },
+});
+ruleTester.run('template-no-obsolete-elements', rule, {
+  valid: ['<template><div></div></template>'],
+  invalid: [
+    { code: '<template><marquee></marquee></template>', errors: [{ messageId: 'obsolete' }] },
+  ],
+});
