Skip to content

Support ember-try.cjs #1089

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NullVoxPopuli wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Support ember-try.cjs #1089

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions lib/utils/config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,14 @@ function getConfigPath(cwd) {
return possibleConfigPath;
}

let cjsPath = path.join('config', 'ember-try.cjs');

if (fs.existsSync(cjsPath)) {
debug(`using config from config/ember-try.cjs`);

return cjs;
}

debug('using config from config/ember-try.js');

return path.join('config', 'ember-try.js');
Expand Down Expand Up @@ -53,7 +61,7 @@ async function getBaseConfig(options) {
return await mergeAutoConfigAndConfigFileData(autoConfig, data);
} else {
throw new Error(
'No ember-try configuration found. Please see the README for configuration options',
'No ember-try configuration found. Please see the README for configuration options'
);
}
}
Expand All @@ -69,7 +77,9 @@ async function config(options) {

if (typeof configData[oldOption] === 'boolean') {
warn(
`${prefix('ember-try DEPRECATION')} The \`${oldOption}\` config option is deprecated. Please use \`packageManager: '${name}'\` instead.`,
`${prefix(
'ember-try DEPRECATION'
)} The \`${oldOption}\` config option is deprecated. Please use \`packageManager: '${name}'\` instead.`
);

delete configData[oldOption];
Expand Down