Set allow-failure on every try scenario#318
Merged
NullVoxPopuli merged 1 commit intoember-cli:nvp/its-vite-timefrom Apr 18, 2026
Merged
Conversation
The CI's try-scenarios job has `continue-on-error: ${{ matrix.allow-failure }}`,
but @embroider/try's list command passes scenario objects through verbatim
(apart from normalizing env). Because none of the scenarios defined an
allow-failure key, the expression evaluated to '' and GitHub Actions rejected
it as a non-boolean, preventing the job from being created at all. The overall
run was marked failed even though every other job passed.
Define allow-failure on each scenario: true for the bleeding-edge ember-beta
and ember-alpha scenarios, false everywhere else.
Co-Authored-By: Claude Opus 4.7 (1M context) <[email protected]>
NullVoxPopuli
approved these changes
Apr 18, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the silent failure on the
Vitebranch where thetry-scenariosjob never appears in the CI run but the overall run is markedfailure.The workflow has:
@embroider/try'slistcommand passes scenario objects through almost verbatim (onlyenv: {}is defaulted in). Since none of the scenarios intest-app/.try.mjsdefinedallow-failure,${{ matrix.allow-failure }}evaluated to'', which GitHub Actions rejects as a non-boolean. The annotation on run24614721563confirms:Because the matrix failed to materialize, no try-scenarios job was created, yet the workflow run was marked
failure— which is why the 13 visible checks are all green while the PR shows red.This PR defines
allow-failureon every scenario:truefor the bleeding-edgeember-betaandember-alphascenarios,falseeverywhere else.Test plan
try-scenariosjobs (min-supported, ember-lts-4.12, ember-lts-5.12, ember-lts-6.4, ember-latest, ember-beta, ember-alpha) actually get createdcontinue-on-errorevaluating to''no longer appears🤖 Generated with Claude Code