Skip to content

Remove extra space from package.exports default entry#95

Merged
mansona merged 1 commit intoember-cli:mainfrom
phil-mellor:fix/space-in-export-default
Oct 13, 2025
Merged

Remove extra space from package.exports default entry#95
mansona merged 1 commit intoember-cli:mainfrom
phil-mellor:fix/space-in-export-default

Conversation

@phil-mellor
Copy link
Copy Markdown
Contributor

Hi there. This is my first PR contribution on GitHub so please bear with me if I'm doing something wrong!

This PR fixes the error [commonjs--resolver] Failed to resolve entry for package ".....". The package may have incorrect main/module/exports specified in its package.json: No known conditions for "." specifier in "....." package when importing from the addon package.

There's a leading space in exports/./ default that needs removing.

Currently the addon's package.json looks like this:

"exports": {
    ".": {
      "types": "./declarations/index.d.ts",
      " default": "./dist/index.js"
    },
    "./addon-main.js": "./addon-main.cjs",
    "./*.css": "./dist/*.css",
    "./*": {
      "types": "./declarations/*.d.ts",
      "default": "./dist/*.js"
    }
  }

@mansona mansona added the bug Something isn't working label Oct 13, 2025
Copy link
Copy Markdown
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I noticed this the other day but didn't get a chance to fix it 😂 thanks for the contribution 🎉

@mansona mansona merged commit 8c0c95d into ember-cli:main Oct 13, 2025
15 checks passed
@mansona mansona changed the title Remove space from { " default": "./dist/*.js" } Remove extra space from package.exports default entry Oct 13, 2025
@github-actions github-actions Bot mentioned this pull request Oct 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants