Skip to content

chore: remove @glint/environment-ember-*#90

Merged
NullVoxPopuli merged 6 commits intoember-cli:mainfrom
aklkv:feat/glint-imports
Oct 6, 2025
Merged

chore: remove @glint/environment-ember-*#90
NullVoxPopuli merged 6 commits intoember-cli:mainfrom
aklkv:feat/glint-imports

Conversation

@aklkv
Copy link
Copy Markdown
Contributor

@aklkv aklkv commented Oct 6, 2025

  • remove some leftover @glint/environment-ember-*

Question should we keep registry things at all? 🤔
declare module '@glint/environment-ember-loose/registry' {

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

Question should we keep registry things at all?

the declare module stuff can be removed, but the template-registry file I think can stay

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

re: the failures, you can update the snapshots -- this is caused by a floating glint change, which was a bugfix

@aklkv
Copy link
Copy Markdown
Contributor Author

aklkv commented Oct 6, 2025

do we still need @glint/tsserver-plugin ?

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

ya, it's needed for non-vscode editors as a signal to TS integrations to automatically switch between TS and TS + plugins in the nearest project / folder with a package.json

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Oct 6, 2025
@NullVoxPopuli NullVoxPopuli merged commit d2ddea5 into ember-cli:main Oct 6, 2025
13 checks passed
@github-actions github-actions Bot mentioned this pull request Oct 6, 2025
@aklkv aklkv deleted the feat/glint-imports branch October 6, 2025 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants