Skip to content

eslint: if projectService is used, project should be removed#115

Merged
NullVoxPopuli merged 1 commit intoember-cli:mainfrom
evoactivity:typescript-fixes
Nov 11, 2025
Merged

eslint: if projectService is used, project should be removed#115
NullVoxPopuli merged 1 commit intoember-cli:mainfrom
evoactivity:typescript-fixes

Conversation

@evoactivity
Copy link
Copy Markdown
Contributor

Currently you will receive a lint warning if both are used together.

Docs show to remove it when projectService is used.
https://typescript-eslint.io/blog/project-service/#configuration

@evoactivity
Copy link
Copy Markdown
Contributor Author

Not sure if that one failure is related, I wouldn't have thougt so :/

@evoactivity
Copy link
Copy Markdown
Contributor Author

Seems the failing test is related to this
embroider-build/embroider#2609

@NullVoxPopuli NullVoxPopuli added the bug Something isn't working label Nov 11, 2025
@NullVoxPopuli NullVoxPopuli merged commit 834b038 into ember-cli:main Nov 11, 2025
38 of 40 checks passed
@github-actions github-actions Bot mentioned this pull request Nov 11, 2025
@mkszepp
Copy link
Copy Markdown
Contributor

mkszepp commented Nov 12, 2025

Fyi: we have recenty readded project: true in app blueprint cause of issue with eslint and imports with file extension gts

ember-cli/ember-app-blueprint#126

Now i think you have broken in addon this... we need to patch this and other lines in eslint-parser:

https://github.com/ember-tooling/ember-eslint-parser/blob/74b7345d3385d0c768ae96aa7d352bf3e9a72df7/src/parser/gjs-gts-parser.js#L162-L164

@NullVoxPopuli
Copy link
Copy Markdown
Contributor

addons require extensions -- so is there anything to still fix here?

@mkszepp
Copy link
Copy Markdown
Contributor

mkszepp commented Nov 12, 2025

i think the change of @evoactivity are good and should be done also inside app blueprint, but before we do this in app, we need to patch ember-eslint-parser...

I can confirm, that now i have the same issue in addon 😭:

grafik

To fix this => we should landed this as patch: ember-tooling/ember-eslint-parser#142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants