Skip to content

fix: handle numeric defaultZoomLevel on document load #609

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aleksei-y wants to merge 2 commits into
base: main
Choose a base branch
from
+21 −10
Open

fix: handle numeric defaultZoomLevel on document load #609

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
121896a
fix: handle numeric defaultZoomLevel on document load
aleksei-y Apr 27, 2026
9dbd03f
fix: apply numeric zoom after viewport resize instead of recalcAuto
aleksei-y Apr 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 21 additions & 10 deletions packages/plugin-zoom/src/lib/zoom-plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,12 +85,24 @@ export class ZoomPlugin extends BasePlugin<

// Keep automatic modes up to date per document
this.viewport.onViewportResize(
(event) => this.recalcAuto(event.documentId, VerticalZoomFocus.Top),
{
mode: 'debounce',
wait: 150,
keyExtractor: (event) => event.documentId,
},
(event) => {
const docState = this.getDocumentState(event.documentId);
if (!docState) return;

if (typeof docState.zoomLevel === 'number') {
this.handleRequest(
{ level: docState.zoomLevel, focus: VerticalZoomFocus.Top },
event.documentId
);
return;
}
this.recalcAuto(event.documentId, VerticalZoomFocus.Top);
},
{
mode: 'debounce',
wait: 150,
keyExtractor: (event) => event.documentId,
},
);

// Subscribe to spread changes
Expand Down Expand Up @@ -529,11 +541,10 @@ export class ZoomPlugin extends BasePlugin<
private recalcAuto(documentId: string, focus?: VerticalZoomFocus) {
const docState = this.getDocumentState(documentId);
if (!docState) return;

if (
docState.zoomLevel === ZoomMode.Automatic ||
docState.zoomLevel === ZoomMode.FitPage ||
docState.zoomLevel === ZoomMode.FitWidth
docState.zoomLevel === ZoomMode.Automatic ||
docState.zoomLevel === ZoomMode.FitPage ||
docState.zoomLevel === ZoomMode.FitWidth
) {
this.handleRequest({ level: docState.zoomLevel, focus }, documentId);
}
Expand Down