fix(i18n): allow localization of early loading states via useStaticTranslation#590
Open
kheireddinebou wants to merge 1 commit intoembedpdf:mainfrom
Open
fix(i18n): allow localization of early loading states via useStaticTranslation#590kheireddinebou wants to merge 1 commit intoembedpdf:mainfrom
kheireddinebou wants to merge 1 commit intoembedpdf:mainfrom
Conversation
|
@kheireddinebou is attempting to deploy a commit to the OpenBook Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the early rendering states of the PDF viewer ("Initializing PDF engine...", "Initializing plugins...") are always displayed in English, regardless of the user's localized configuration.
Because loading indicators appear before the plugin system and dynamic translation hooks (
useTranslations) are fully mounted, a static capability is needed to resolve simple translations from the configuration object synchronously.Implementation Details
useStaticTranslationinside@embedpdf/plugin-i18n.localesanddefaultLocalefrom the config and manually traverses the translation keys statically..mdxfiles) and theCHANGELOG.mdto reflect the availability of the newuseStaticTranslationfunction.Related Issue
Closes #589
Pull Request Checklist
useStaticTranslationfunctionalitypnpm build:watch)