Add CSS parser round-trip structure tests#3974
Open
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Open
Add CSS parser round-trip structure tests#3974vogella wants to merge 1 commit intoeclipse-platform:masterfrom
vogella wants to merge 1 commit intoeclipse-platform:masterfrom
Conversation
Contributor
Test Results 855 files 855 suites 53m 40s ⏱️ Results for commit 710e760. ♻️ This comment has been updated with latest results. |
vogella
force-pushed
the
css-engine-parser-roundtrip-tests
branch
from
2359572 to
f57a0cb
Compare
Adds 12 tests covering the structural shape the engine's CSS parser produces, asserted only through the high-level DOM-CSS interfaces (CSSStyleSheet, CSSRule, CSSStyleDeclaration, CSSValue). Covers empty sheets, single rule, rule order preservation, multiple selectors per rule, multiple declarations, whitespace and comment tolerance, @import rule type and href exposure, quoted vs unquoted attribute values, color value forms (#rgb, #rrggbb, rgb(), named), and that invalid input either throws or invokes the error handler. Adds parseCssWithoutImports to ParserTestUtil so the @import tests can inspect the raw AST without the engine's eager URL resolution pass.
vogella
force-pushed
the
css-engine-parser-roundtrip-tests
branch
from
f57a0cb to
710e760
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds twelve structural tests over the CSS parser's output, asserted purely through the high-level DOM-CSS interfaces (
CSSStyleSheet,CSSRule,CSSStyleDeclaration,CSSValue). Covers empty sheets, single rule shape, rule order preservation, multiple selectors in one rule, multiple declarations, whitespace and comment tolerance,@importrule type and href exposure, quoted and unquoted attribute values, the four CSS color forms (#rgb,#rrggbb,rgb(), named), and that invalid input either throws or invokes the error handler.A small helper
parseCssWithoutImportsis added toParserTestUtilso the@importtests can inspect the raw AST without the engine's eager URL resolution pass.