[pull] trunk from WordPress:trunk#1982
Open
pull[bot] wants to merge 1878 commits intodraganescu:trunkfrom
Open
[pull] trunk from WordPress:trunk#1982pull[bot] wants to merge 1878 commits intodraganescu:trunkfrom
pull[bot] wants to merge 1878 commits intodraganescu:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @felixarntz, @desrosj602fd350-edb4-49c9-b593-d223f7449a82. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Enable client-side media processing in the three `test_finalize_item*` tests so the `/finalize` route is registered before dispatching requests. Without this, the route does not exist and all assertions fail with `rest_no_route`. Extracts the repeated filter-and-reinitialize pattern into a shared `enable_client_side_media_processing()` helper, used by both the sideload and finalize tests. Follow-up to [61982]. git-svn-id: https://develop.svn.wordpress.org/trunk@61984 602fd350-edb4-49c9-b593-d223f7449a82
…masking. Add `_wp_connectors_get_api_key_source()` to detect whether an API key is configured via environment variable, PHP constant, or database. The UI uses this to show the key source and hide "Remove and replace" for externally configured keys. Replace `_wp_connectors_validate_keys_in_rest()` and `_wp_connectors_get_real_api_key()` with a single `rest_post_dispatch` handler, `_wp_connectors_rest_settings_dispatch()`, that masks keys in all `/wp/v2/settings` responses and validates on POST/PUT, reverting invalid keys. Simplify `_wp_register_default_connector_settings()` by replacing the closure-based `sanitize_callback` and `option_` mask filter with plain `sanitize_text_field`, since masking is now handled at the REST layer. Enrich `_wp_connectors_get_connector_script_module_data()` to expose `keySource`, `isConnected`, `logoUrl`, and plugin `isInstalled` / `isActivated` status to the admin screen. Update `_wp_connectors_pass_default_keys_to_ai_client()` to skip keys sourced from environment variables or constants and read the database directly via `get_option()`. Set `_wp_connectors_init` priority to 15 so the registry is ready before settings are registered at priority 20. Backports WordPress/gutenberg#76266. Backports WordPress/gutenberg#76327. Props jorgefilipecosta, gziolo, swissspidy, flixos90. Fixes #64819. git-svn-id: https://develop.svn.wordpress.org/trunk@61985 602fd350-edb4-49c9-b593-d223f7449a82
In performance tests, editing large documents in the site-editor suite (loading large-post.html) can cause performance tests in the site editor to time out with memory errors. Developed in: #11181. Props alecgeatches, mukesh27. See #64622. git-svn-id: https://develop.svn.wordpress.org/trunk@61986 602fd350-edb4-49c9-b593-d223f7449a82
Use `rest_is_field_included()` instead of `in_array()` for `content`, `title`, `excerpt`, and `guid` fields in `WP_REST_Revisions_Controller`. This lets clients request specific sub-fields (e.g. `_fields=content.raw`) and skip expensive `the_content` rendering. The [REST API `_fields` documentation](https://developer.wordpress.org/rest-api/using-the-rest-api/global-parameters/#_fields) states that nested fields are supported using dot notation. However, the revisions controller uses `in_array()` which doesn't match nested keys like `content.raw`. Developed in: #11230. Props ellatrix, andrewserong, mukeshpanchal27. Fixes #64844. git-svn-id: https://develop.svn.wordpress.org/trunk@61987 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned hash from the `gutenberg` from `9b8144036fa5faf75de43d4502ff9809fcf689ad` to `8c78d87453509661a9f28f978ba2c242d515563b`. The following changes are included: - Navigation Editor: Allow any blocks to be inserted by gating contentOnly insertion rules to section blocks (WordPress/gutenberg#76189) - Add `fetchpriority=low` to `IMG` tags in collapsed Details blocks (WordPress/gutenberg#76269) - Connectors: Add logo URL support for custom AI providers (WordPress/gutenberg#76190) - Cover Block: Add a playlist parameter to loop YouTube background videos. (WordPress/gutenberg#76004) - Connectors: Memoize getConnectors selector (WordPress/gutenberg#76339) - HTML Block: Fix broken layout (WordPress/gutenberg#76278) - Tests: Skip connector logo URL tests when AI Client is unavailable (WordPress/gutenberg#76343) - Navigation Overlay: Explicitly set fetchpriority for images (WordPress/gutenberg#76208) - Connectors: Show API key source for env vars and wp-config constants (WordPress/gutenberg#76355) - Connectors: Move API key validation and masking to REST dispatch level (WordPress/gutenberg#76327) - Connectors: Replace apiFetch with core-data store selectors (WordPress/gutenberg#76333) - Do not sync local attributes (WordPress/gutenberg#76267) - Add `fetchpriority=low` to `IMG` tags in collapsed Accordion Item blocks (WordPress/gutenberg#76336) - Implement disconnection debounce after initial connection (WordPress/gutenberg#76114) - Allow Post Content to be edited when 'Show template' is active and Post content is nested in a Template Part (WordPress/gutenberg#76305) - Fix: Document Bar: Back button flickers (WordPress/gutenberg#76320) - RTC: Move event hooks from editor to core-data (WordPress/gutenberg#76358) - fix(navigation): prevent right-justified submenu overflow in custom overlays (WordPress/gutenberg#76360) - Connectors: Add connectors registry for extensibility (WordPress/gutenberg#76364) - Connectors: Add empty state when no connectors are registered (WordPress/gutenberg#76375) - Temp: Disable RTC in the site editor (WordPress/gutenberg#76223) - Connectors: Add AI Experiments plugin callout with install/activate functionality (WordPress/gutenberg#76379) - Editor: Polish real-time collaboration presence UI and move Avatar to editor package (WordPress/gutenberg#75652) (WordPress/gutenberg#76365) - RTC: Add collaborator selection highlighting in rich text (WordPress/gutenberg#76107) - Sync changes from `wp_enqueue_global_styles()` to Gutenberg override (WordPress/gutenberg#76127) - [RTC] Fix performance regression on post save (WordPress/gutenberg#76370) - Media: Enable AVIF support for client-side uploads (WordPress/gutenberg#76371) - Connectors: Move plugin status computation to script module data (WordPress/gutenberg#76409) - Revisions: Skip rendered fields in REST API responses (WordPress/gutenberg#76347) - E2E Tests: Add connector setup flow tests with test AI provider (WordPress/gutenberg#76433) - RTC: Place sync connection modal in front of popover (WordPress/gutenberg#76431) - Connectors: Sync PHP code with WordPress Core (WordPress/gutenberg#76443) - Editor: Show own presence in collaborative editing sessions (WordPress/gutenberg#76413) (WordPress/gutenberg#76445) A full list of changes can be found on GitHub: https://github.com/WordPress/gutenberg/compare/9b8144036fa5faf75de43d4502ff9809fcf689ad…8c78d87453509661a9f28f978ba2c242d515563b. Log created with: git log --reverse --format="- %s" 9b8144036fa5faf75de43d4502ff9809fcf689ad..8c78d87453509661a9f28f978ba2c242d515563b | sed 's|#\([0-9][0-9]*\)|https://github.com/WordPress/gutenberg/pull/\1|g; /github\.com\/WordPress\/gutenberg\/pull/!d' | pbcopy See #64595. git-svn-id: https://develop.svn.wordpress.org/trunk@61988 602fd350-edb4-49c9-b593-d223f7449a82
…sign. Developed in #11026 Props juanfra, westonruter, jeffpaul, mukesh27, audrasjb, joedolson, dd32, davidbaumwald, fabiankaegy, huzaifaalmesbah, Joen, butterflymedia, noruzzaman, karmatosed, ozgursar, fcoveram, tusharaddweb, darshitrajyaguru97. See #64308. Fixes #64708. git-svn-id: https://develop.svn.wordpress.org/trunk@61989 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61990 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@61991 602fd350-edb4-49c9-b593-d223f7449a82
This commit simply removes a `$network_exists` variable (introduced in r41384) that was never used. Props mukesh27, Soean. Fixes #64851. git-svn-id: https://develop.svn.wordpress.org/trunk@61992 602fd350-edb4-49c9-b593-d223f7449a82
Developed in #11205 Props apermo, mukesh27. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61994 602fd350-edb4-49c9-b593-d223f7449a82
Update incorrect uses of `null` as a single parameter type to be `mixed` instead, largely targeting `$deprecated` variable names. Pipe `|` a few `null`s with other valid types where appropriate. Add a missing empty new-line between the `_deprecated_file()` and `_deprecated_argument()` functions. See #64224. git-svn-id: https://develop.svn.wordpress.org/trunk@61995 602fd350-edb4-49c9-b593-d223f7449a82
When an attachment is used by multiple posts, it could be included in `_embed` for a published post even if its `post_parent` is a draft. This commit avoids embedding attachments that are not viewable in this context. Props bor0. Fixes #64183. git-svn-id: https://develop.svn.wordpress.org/trunk@61996 602fd350-edb4-49c9-b593-d223f7449a82
…ded with a `null` parent. Developed in #11055 Props sky_76, westonruter, ozgursar, sabernhardt. Fixes #64728. git-svn-id: https://develop.svn.wordpress.org/trunk@61997 602fd350-edb4-49c9-b593-d223f7449a82
The `rest_revision_query` filter in `WP_REST_Revisions_Controller::get_items()` carried a cross-reference comment claiming it was documented in the posts controller. This was incorrect, as the posts controller documents `rest_{$this->post_type}_query` — a dynamic hook that fires only for post types managed by `WP_REST_Posts_Controller`.
`WP_REST_Revisions_Controller` extends `WP_REST_Controller` directly (not the posts controller), so the dynamic hook never fires for revisions. `rest_revision_query` is a standalone hook and has never had its own PHPDoc block.
Follow-up to [43584].
Props apermo, mukesh27, SergeyBiryukov.
See #64224.
git-svn-id: https://develop.svn.wordpress.org/trunk@61998 602fd350-edb4-49c9-b593-d223f7449a82
Replace `@group rest-api` with `@group restapi` to unify the tests under the one group name, chosen on the basis that majority rules. Follow up to r61045, r61032. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@61999 602fd350-edb4-49c9-b593-d223f7449a82
…it_link()` which is being passed in some templates. This addresses `arguments.count` errors identified by PHPStan at rule level 1. Developed in #11242 Follow-up to WordPress/twentyseventeen commits: [WordPress/twentyseventeen@1afb73c 1afb73c], [WordPress/twentyseventeen@7dd3025#diff-88ec0e9d51b04231a448a06c40ced21810e85361ced9481a9248f1075226c6aa 7dd3025], [https://github.com/WordPress/twentyseventeen/blob/69482880b4ae2ec145f60df417423665581a5653/inc/template-tags.php#L104-L128 6948288]. Props sabernhardt, westonruter. See #64680. Fixes #64825. git-svn-id: https://develop.svn.wordpress.org/trunk@62000 602fd350-edb4-49c9-b593-d223f7449a82
This improves how the built Gutenberg asset is retrieved from the GitHub Container Registry to avoid situations where the download fails when the directory already exists. - The related `postinstall` command has changed from `gutenberg:download` to `gutenberg:verify`. - The `--force` option has been removed. `gutenberg:download` will now download a fresh copy every time it's run. - The `gutenberg:verify` script is now the preferred entry point for managing the files within the `gutenberg` directory. It will only trigger a downoad if the hashes do not match, or the folder is missing entirely. Follow up to [61438], [61873], [61874]. Props bernhard-reiter. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62021 602fd350-edb4-49c9-b593-d223f7449a82
In MySQL 8.0, the default authentication plugin changed from `mysql_native_password` to `caching_sha2_password`, which is not available in PHP 7.3 and earlier. The installation testing workflow currently accounts for this, but only for PHP 7.2 & 7.3. It also does not account for a change in MySQL 8.4 which changed the related flag for controlling this from `--default-authentication-plugin` to `--authentication-policy`. This adjusts the flags and surrounding conditions to ensure the correct ones are passed for the right combinations. Props johnbillion. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62022 602fd350-edb4-49c9-b593-d223f7449a82
This excludes MySQL 9.5 jobs for the installation testing workflow. Only the most recent innovation release of MySQL should be tested. Follow up to [61875]. See #64225, #64227. git-svn-id: https://develop.svn.wordpress.org/trunk@62023 602fd350-edb4-49c9-b593-d223f7449a82
…date_link()`. Follow-up to [8758], [15564]. Props marian1. Fixes #64764. git-svn-id: https://develop.svn.wordpress.org/trunk@62024 602fd350-edb4-49c9-b593-d223f7449a82
This changeset introduces the `wp_admin_bar_add_color_scheme_to_front_end()` which is hooked on `admin_bar_init` in order to use the CSS from admin color schemes on the admin bar on front-end, as inline styles. Props sabernhardt, huzaifaalmesbah, audrasjb, johnbillion, noruzzaman, JeffPaul, joedolson, huzaifaalmesbah, amesplant, r1k0, shailu25. Fixes #64762. git-svn-id: https://develop.svn.wordpress.org/trunk@62025 602fd350-edb4-49c9-b593-d223f7449a82
This changeset prevents users from removing their own role when bulk editing user roles. Props jomonthomaslobo1, johnbillion, hugod, audrasjb, shailu25, rishavdutta, rollybueno. Fixes #63068. git-svn-id: https://develop.svn.wordpress.org/trunk@62026 602fd350-edb4-49c9-b593-d223f7449a82
Fix two conditional checks for validity of data when importing alt text from IPTC meta data. Strictly compare the results of `strpos()` as a boolean, rather than treating 0 as false; return string if `file_get_contents()` returns false. Props suhan2411, pbiron, alexodiy, joedolson. Fixes #64849. git-svn-id: https://develop.svn.wordpress.org/trunk@62027 602fd350-edb4-49c9-b593-d223f7449a82
This addresses 3 PHPStan errors at rule level 8: * `arguments.count`: Function `wp_cache_switch_to_blog_fallback()` invoked with 1 parameter, 0 required. * `method.nonObject`: Cannot call method `switch_to_blog()` on `class-string|object`. * `missingType.return`: Function `wp_cache_switch_to_blog()` has no return type specified. Developed as subset of #11151 Follow-up to r61760. Props westonruter, johnjamesjacoby. See #23290, #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@62028 602fd350-edb4-49c9-b593-d223f7449a82
…versions. An empty `iref` box is pointless but is allowed by the specification. This commit imports an upstream fix from libavifinfo. Follow-up to [57524], [58049]. Props yguyon. Fixes #64669. git-svn-id: https://develop.svn.wordpress.org/trunk@62029 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61179]. Props sanketparmar, mukesh27. See #64244. git-svn-id: https://develop.svn.wordpress.org/trunk@62030 602fd350-edb4-49c9-b593-d223f7449a82
…s for values that resolve to "true" or "false" strings. See #64227 git-svn-id: https://develop.svn.wordpress.org/trunk@62253 602fd350-edb4-49c9-b593-d223f7449a82
…hat trail pinned actions. None of these actions use `v`-prefixed tag names. See #64227 git-svn-id: https://develop.svn.wordpress.org/trunk@62254 602fd350-edb4-49c9-b593-d223f7449a82
…_Builder`. This checks that the return value of the `wp_ai_client_default_request_timeout` filter is a non-negative number before passing it to `RequestOptions`. If the filtered value is invalid, it is discarded in favor of the original default of `30.0` and a `_doing_it_wrong()` notice is issued. Without this check, a fatal error would ensue from the exception thrown in `\WordPress\AiClient\Providers\Http\DTO\RequestOptions::validateTimeout()`. The following static analysis issues are addressed: * Use `float` instead of `int` for the `wp_ai_client_default_request_timeout` filter parameter. * Add missing PHP imports for `Message` and `MessagePart` in the PHPDoc for `wp_ai_client_prompt()`. * Add PHP return type hints for `wp_ai_client_prompt()` and `WP_AI_Client_Cache::getMultiple()`. * Use native property type hints in `WP_AI_Client_HTTP_Client`. Developed in #11596 Props westonruter, justlevine, flixos90, khushdoms, darshitrajyaguru97, adrmf25, jarodortegaaraya, tusharaddweb, gaurangsondagar. Fixes #65094. git-svn-id: https://develop.svn.wordpress.org/trunk@62255 602fd350-edb4-49c9-b593-d223f7449a82
Props timse201, sanketparmar, trickster301, audrasjb, jadavsanjay, SergeyBiryukov. Fixes #64982. git-svn-id: https://develop.svn.wordpress.org/trunk@62256 602fd350-edb4-49c9-b593-d223f7449a82
…ss capability Adds capability-gated CSS stripping so that when a user without `edit_css` saves a post, any `style.css` block attributes are removed from block comments using `WP_Block_Parser::next_token()`. Props aaronrobertshaw, audrasjb, dmsnell, glendaviesnz, jonsurrell, ozgursar, ramonopoly, shailu25, westonruter. Follow-up to [64544]. Fixes #64771. git-svn-id: https://develop.svn.wordpress.org/trunk@62257 602fd350-edb4-49c9-b593-d223f7449a82
… files are minified. Relocates the copying of vendor JavaScript files back to the `grunt copy:vendor-js` subtask to ensure the files are in place prior to the `grunt uglify` step running to minify the files. Props desrosj. Fixes #65007. See #64393. git-svn-id: https://develop.svn.wordpress.org/trunk@62258 602fd350-edb4-49c9-b593-d223f7449a82
Includes moving the data provider after the corresponding test for consistency with the rest of the test suite. Follow-up to [43751]. Props sagardeshmukh. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@62259 602fd350-edb4-49c9-b593-d223f7449a82
Includes removing redundant tags to help clarify the purpose of each individual test. Follow-up to [42255], [50339]. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@62260 602fd350-edb4-49c9-b593-d223f7449a82
…ta()` tests. Follow-up to [59132]. Props sagardeshmukh. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@62261 602fd350-edb4-49c9-b593-d223f7449a82
This changeset corrects a misalignment issue affecting the show/hide button next to the password field. Props piyushpatel123, rajdiptank111, ankitkumarshah, andrewssanya, jdahir0789, gautammkgarg, gaurangsondagar, gaisma22, ugyensupport, abduremon, ankitmaru, darshitrajyaguru97, khushdoms, monzuralam. Fixes #65031. git-svn-id: https://develop.svn.wordpress.org/trunk@62262 602fd350-edb4-49c9-b593-d223f7449a82
Reduces the size and improves the alignment of the post slug field following the re-design of form elements as part of the new admin theme. Props wildworks, sabernhardt, audrasjb, dhruvang21, shailu25, joedolson, khushdoms, tusharaddweb. Fixes #65063. git-svn-id: https://develop.svn.wordpress.org/trunk@62263 602fd350-edb4-49c9-b593-d223f7449a82
…related tests. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@62264 602fd350-edb4-49c9-b593-d223f7449a82
Modifies the Screen Options > Number of items per page field to avoid cropping of three digit numbers when setting a list view to display a lot of items. Props apermo, audrasjb, darshitrajyaguru97, ekla, gaurangsondagar, jigarkahar, juanmaguitar, khushdoms, peterwilsoncc, sabernhardt, shailu25, shatrumyatra, yusufmudagal. Fixes #65104. git-svn-id: https://develop.svn.wordpress.org/trunk@62268 602fd350-edb4-49c9-b593-d223f7449a82
This update adds 1 certificate to the bundle. Props desrosj. Fixes #64245. git-svn-id: https://develop.svn.wordpress.org/trunk@62271 602fd350-edb4-49c9-b593-d223f7449a82
… mobile. In [62262], the show/hide button next to the password field was aligned using `line-height` and `vertical-align`. This approach left the icon misaligned on mobile viewports. Follow-up to [62262]. Props mukesh27, wildworks. Fixes #65031. git-svn-id: https://develop.svn.wordpress.org/trunk@62272 602fd350-edb4-49c9-b593-d223f7449a82
Align the Previous, Next, and Restore This Revision buttons consistently across viewports on the revisions comparison screen. Props audrasjb, mokshasharmila13, peterwilsoncc, presskopp, shailu25, wildworks. Fixes #65062. git-svn-id: https://develop.svn.wordpress.org/trunk@62273 602fd350-edb4-49c9-b593-d223f7449a82
Add automatic translation loading for script modules (ES modules), so strings using `__()` and friends from `@wordpress/i18n` can be translated at runtime. This brings classic script i18n parity to script modules registered via `wp_register_script_module()`, which previously had no way to load translation data, leaving strings untranslated on screens like Connectors and Fonts that are built as script modules. At the `admin_print_footer_scripts` and `wp_footer` actions, every enqueued script module and its dependencies are walked, the translation chunk is loaded for each, and an inline `<script>` calls `wp.i18n.setLocaleData()` so translations are available before deferred modules execute. Note there is currently a runtime dependency on the `wp-i18n` classic script, which is printed just-in-time if not already enqueued. This coupling is to be removed in a future release. Public API: * `WP_Script_Modules::set_translations()` stores the text domain (and optional path) per registered module to override the text domain and path. A global `wp_set_script_module_translations()` function is added as a wrapper around `wp_script_modules()->set_translations()`. * `WP_Script_Modules::get_registered()` obtains a registered module's data. See #60597. * `WP_Script_Modules::print_script_module_translations()` emits inline `wp.i18n.setLocaleData()` calls after classic scripts load but before modules execute. * `load_script_module_textdomain()` loads the translation data for a given script module ID and text domain. * The existing `load_script_textdomain_relative_path` filter gains a third `$is_module` parameter so callers can distinguish classic-script and script-module lookups when resolving translation paths. PHPStan types are also added in `WP_Script_Modules`. See #64238. Developed in #11543 Props manzoorwanijk, westonruter, jsnajdr, jonsurrell, mukesh27, peterwilsoncc, 369work, desrosj, sabernhardt, nilambar, jorgefilipecosta, malayladu. See #64238, #60597. Fixes #65015. git-svn-id: https://develop.svn.wordpress.org/trunk@62278 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [38880], [61645]. Props umesh.nevase, sabernhardt, SergeyBiryukov. Fixes #65133. git-svn-id: https://develop.svn.wordpress.org/trunk@62279 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [58303]. See #64225. git-svn-id: https://develop.svn.wordpress.org/trunk@62281 602fd350-edb4-49c9-b593-d223f7449a82
Introduces a JavaScript fallback for determining whether the command palette icon in the toolbar should display ⌘Kfor Apple devices. This is to account for sites behind a CDN as it's common for the User-Agent header to be stripped from the request sent to the application server in order to increase cache hits on the edge. Props peterwilsoncc, westonruter, mukesh27, ramonopoly. Fixes #65121. git-svn-id: https://develop.svn.wordpress.org/trunk@62282 602fd350-edb4-49c9-b593-d223f7449a82
…th classic editor. Follow-up to [61646], [61759]. Props umeshnevase, sabernhardt, SergeyBiryukov. Fixes #65141. git-svn-id: https://develop.svn.wordpress.org/trunk@62284 602fd350-edb4-49c9-b593-d223f7449a82
Adds an optional `is_active` callable to the `plugin` definition accepted by `WP_Connector_Registry::register()`. The callback receives no arguments, must return a boolean, and is used by the Connectors screen to decide whether a connector's backing plugin is currently active. When omitted, it defaults to `__return_true`; when provided but not callable, registration fails with a `_doing_it_wrong()` notice. Developed in: #11565 Props iamadisingh, jorgefilipecosta, mukesh27, gziolo. Fixes #65020. git-svn-id: https://develop.svn.wordpress.org/trunk@62288 602fd350-edb4-49c9-b593-d223f7449a82
Update `_wp_register_default_connector_settings()` to register a connector's default API key setting only when the connector's `plugin.is_active` callback returns `true`. Add tests covering the gate's branches: setting skipped when `is_active` returns `false`, setting registered when it returns `true`. Props jorgefilipecosta, gziolo, peterwilsoncc. Fixes #65099. git-svn-id: https://develop.svn.wordpress.org/trunk@62289 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Props wildworks, mukesh27, shailu25, noruzzaman, darshitrajyaguru97, SergeyBiryukov. Fixes #64987. git-svn-id: https://develop.svn.wordpress.org/trunk@62290 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Props wildworks, anupkankale, shailu25, gaurangsondagar, jadavsanjay, SergeyBiryukov. Fixes #65131. git-svn-id: https://develop.svn.wordpress.org/trunk@62291 602fd350-edb4-49c9-b593-d223f7449a82
This adds a PHPStan extension with a parser-node visitor that bridges WordPress core's `@global Type $varname` PHPDoc convention to PHPStan's variable type resolution, eliminating 3,784 spurious errors caused by globals resolving as `mixed` when on rule level 10 (out of 40,069 errors total, so a 9.4% reduction). This avoids the need to add `/** @var Type $varname */` annotations with each global variable. Developed in #11692 Props westonruter, apermo, szepeviktor. See #64898. git-svn-id: https://develop.svn.wordpress.org/trunk@62292 602fd350-edb4-49c9-b593-d223f7449a82
…_src()`. This guards against an undefined index warning being raised when a script or script module is registered with a URL that lacks a path component. This also adds full PHPStan type definitions for `wp_parse_url()`, ensuring that the `_load_script_textdomain_from_src()` function has no PHPStan errors at rule level 10. Developed in #11690 Follow-up to r62278. Props westonruter, manzoorwanijk, mukesh27. See #65015, #64238. git-svn-id: https://develop.svn.wordpress.org/trunk@62293 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Props abcd95, wildworks, mosescursor, sainathpoojary, SergeyBiryukov. See #64999. git-svn-id: https://develop.svn.wordpress.org/trunk@62294 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61646]. Props mohitbsf, wildworks, joedolson, audrasjb, huzaifaalmesbah, SergeyBiryukov. Fixes #64689. git-svn-id: https://develop.svn.wordpress.org/trunk@62295 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [61827], [62171]. Props wildworks, mukesh27, audrasjb, SergeyBiryukov. Fixes #64685. git-svn-id: https://develop.svn.wordpress.org/trunk@62296 602fd350-edb4-49c9-b593-d223f7449a82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.1)
Can you help keep this open source service alive? 💖 Please sponsor : )