Skip to content

[ci] Keep NuGet revocation checks offline - #1536

Merged
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-fix-cfs-network-access
Aug 25, 2026
Merged

[ci] Keep NuGet revocation checks offline#1536
jonathanpeppers merged 1 commit into
mainfrom
jonathanpeppers-fix-cfs-network-access

Conversation

@jonathanpeppers

Copy link
Copy Markdown
Member

Summary

  • set NUGET_CERT_REVOCATION_MODE=offline for Azure pipeline jobs
  • prevent NuGet package-signing verification from contacting public OCSP responders in CFS network-isolated builds
  • preserve the existing approved dotnet-public NuGet source and avoid adding network allowlists

Investigation

AndroidX pipeline 12322 network-isolation telemetry showed ocsp.sectigo.com, ocsp.comodoca.com, and ocsp.entrust.net requests from dotnet.exe in the Windows build job. NuGet.org and Maven Central package traffic is already routed through repository-standard Azure Artifacts feeds on main.

References

Validation

  • dotnet tool restore --configfile NuGet.config with NUGET_CERT_REVOCATION_MODE=offline
  • git diff --check

Prevent NuGet package-signing verification from contacting public OCSP responders in network-isolated Azure builds.

Co-authored-by: Copilot App <[email protected]>
Copilot AI lite review requested due to automatic review settings August 25, 2026 19:09

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure Pipelines shared CI variables to keep NuGet package-signing certificate revocation checks offline, preventing dotnet/NuGet from attempting outbound OCSP requests in network-isolated builds.

Changes:

  • Set NUGET_CERT_REVOCATION_MODE=offline in the CI variables template to avoid contacting public OCSP responders during package signature verification.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@jonathanpeppers

Copy link
Copy Markdown
Member Author

@dalexsoto review

@jonathanpeppers
jonathanpeppers enabled auto-merge (squash) August 25, 2026 21:13

@dalexsoto dalexsoto left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The documented NuGet revocation setting is applied through both pipeline entry points, inherited by all jobs, and the full CI build passes with no new network allowlist.

@jonathanpeppers
jonathanpeppers merged commit 87d87a9 into main Aug 25, 2026
3 checks passed
@jonathanpeppers
jonathanpeppers deleted the jonathanpeppers-fix-cfs-network-access branch August 25, 2026 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants