Skip to content

Fix releases to use trusted publishing (OIDC)#1379

Merged
eddeee888 merged 9 commits intomainfrom
fix-releases
Mar 2, 2026
Merged

Fix releases to use trusted publishing (OIDC)#1379
eddeee888 merged 9 commits intomainfrom
fix-releases

Conversation

@eddeee888
Copy link
Copy Markdown
Collaborator

@eddeee888 eddeee888 commented Feb 28, 2026 •
edited
Loading

Description

We switched to OIDC release. This PR ensures we can release for both snapshot and stable releases

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented Feb 28, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 676d348

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@eddeee888 eddeee888 force-pushed the fix-releases branch 9 times, most recently from f758a58 to bbab851 Compare February 28, 2026 12:03
eddeee888
eddeee888 commented Mar 2, 2026
View reviewed changes
Comment thread packages/presets/near-operation-file/package.json
"repository": {
"type": "git",
"url": "https://github.com/dotansimha/graphql-code-generator-community.git",
"url": "git+https://github.com/dotansimha/graphql-code-generator-community.git",
Copy link
Copy Markdown
Collaborator Author

@eddeee888 eddeee888 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a warning when publishing saying we should add git+, so I apply that suggestion here.

Repository owner deleted a comment from github-actions Bot Mar 2, 2026
eddeee888
eddeee888 commented Mar 2, 2026
View reviewed changes
Comment thread .github/workflows/release.yaml
Comment on lines +16 to +17
id-token: write # allows ODIC publishing
pull-requests: write # allows creating comment with alpha versions
Copy link
Copy Markdown
Collaborator Author

@eddeee888 eddeee888 Mar 2, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm giving each workflow its own permissions that they need, for that extra peace of mind

@eddeee888 eddeee888 changed the title Fix releases Fix releases to use trusted publishing (OIDC) Mar 2, 2026
@eddeee888
Copy link
Copy Markdown
Collaborator Author

eddeee888 commented Mar 2, 2026

There's a failing prettier check, but that's unrelated to this build so I'll merge this first to fix releasing.

@eddeee888 eddeee888 merged commit 98e9d8c into main Mar 2, 2026
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dotansimha dotansimha dotansimha approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eddeee888 @dotansimha