Skip to content
This repository was archived by the owner on Mar 22, 2018. It is now read-only.

Commit c192eca

Browse files
author
Kubernetes Submit Queue
authored
Merge pull request #53714 from FengyunPan/fix-SecurityGroupName
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>. The Securty Group name must be unique Currently the service's name is not unique, and the Securty Group name is not unique too. openstack cloud provider will delete the Securty Group of other loadbalancer service when do a deletion. OpenStack cloud provider get the ID of Securty Group by name, so the Securty Group name must be unique. https://github.com/kubernetes/kubernetes/blob/master/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go#L1262 **Release note**: ```release-note NONE ```
2 parents 49eb961 + f988f50 commit c192eca

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -372,7 +372,7 @@ func popMember(members []v2pools.Member, addr string, port int) []v2pools.Member
372372
}
373373

374374
func getSecurityGroupName(clusterName string, service *v1.Service) string {
375-
return fmt.Sprintf("lb-sg-%s-%v", clusterName, service.Name)
375+
return fmt.Sprintf("lb-sg-%s-%s-%s", clusterName, service.Namespace, service.Name)
376376
}
377377

378378
func getSecurityGroupRules(client *gophercloud.ServiceClient, opts rules.ListOpts) ([]rules.SecGroupRule, error) {

0 commit comments

Comments
 (0)