The Securty Group name should be unique

FengyunPan · FengyunPan · commit f988f503018b · 2017-10-11T19:20:36.000+08:00
Currently the service's name is not unique, and the Securty Group
name is not unique too. openstack cloud provider will delete the
Securty Group of other loadbalancer service when do a deletion.
diff --git a/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go b/pkg/cloudprovider/providers/openstack/openstack_loadbalancer.go
@@ -372,7 +372,7 @@ func popMember(members []v2pools.Member, addr string, port int) []v2pools.Member
 }
 
 func getSecurityGroupName(clusterName string, service *v1.Service) string {
-	return fmt.Sprintf("lb-sg-%s-%v", clusterName, service.Name)
+	return fmt.Sprintf("lb-sg-%s-%s-%s", clusterName, service.Namespace, service.Name)
 }
 
 func getSecurityGroupRules(client *gophercloud.ServiceClient, opts rules.ListOpts) ([]rules.SecGroupRule, error) {

Original file line number	Diff line number	Diff line change
`@@ -372,7 +372,7 @@ func popMember(members []v2pools.Member, addr string, port int) []v2pools.Member`
`372`	`372`	`}`
`373`	`373`
`374`	`374`	`func getSecurityGroupName(clusterName string, service *v1.Service) string {`
`375`		`- return fmt.Sprintf("lb-sg-%s-%v", clusterName, service.Name)`
	`375`	`+ return fmt.Sprintf("lb-sg-%s-%s-%s", clusterName, service.Namespace, service.Name)`
`376`	`376`	`}`
`377`	`377`
`378`	`378`	`func getSecurityGroupRules(client *gophercloud.ServiceClient, opts rules.ListOpts) ([]rules.SecGroupRule, error) {`