chore(test): Improve localcluster tests speed and resiliency#9499
Merged
matthewmcneely merged 15 commits intomainfrom Sep 24, 2025
Merged
Conversation
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the speed and resiliency of LocalCluster tests by parallelizing operations, enhancing health checks, and addressing timing issues.
- Parallelizes container creation, destruction, and health checks to reduce test execution time
- Increases timeout thresholds and improves error suppression to reduce false positives
- Adds support for native dgraph binaries via DGRAPH_BINARY environment variable
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| testutil/docker.go | Increases health check thresholds and adds attempt counters for better logging |
| dgraphtest/local_cluster.go | Parallelizes container operations and health checks using goroutines and wait groups |
| dgraphtest/load.go | Adds support for custom dgraph binary names via DGRAPH_BINARY environment variable |
| dgraphtest/image.go | Adds GOPATH validation and improves logging for binary setup |
| dgraph/cmd/dgraphimport/import_test.go | Adds comprehensive retry logic and helper functions for cluster stability |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| } | ||
|
|
||
| // checkHealthContainer checks health of container and determines wheather container is ready to accept request | ||
| // CheckHealthContainer checks health of container and determines wheather container is ready to accept request |
There was a problem hiding this comment.
There is a spelling error in the comment. 'wheather' should be 'whether'.
Suggested change
| // CheckHealthContainer checks health of container and determines wheather container is ready to accept request | |
| // CheckHealthContainer checks health of container and determines whether container is ready to accept request |
95890df to
d108f7f
Compare
d108f7f to
6adcd4d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR improves the speed and resiliency on tests that rely on the LocalCluster system
Checklist