chore(test): Increase performance of t-harness tests#9485
Merged
matthewmcneely merged 12 commits intomainfrom Aug 22, 2025
Merged
chore(test): Increase performance of t-harness tests#9485matthewmcneely merged 12 commits intomainfrom
matthewmcneely merged 12 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces lazy initialization of Docker container addresses to improve performance of test harness execution. The changes move from global variable initialization to a thread-safe, on-demand address resolution pattern that supports concurrent address lookups and provides fallback values when Docker isn't available.
- Replaces direct global variable access with getter functions that ensure addresses are initialized
- Implements concurrent address resolution using goroutines and sync.WaitGroup for faster startup
- Adds fallback default addresses when Docker containers are not available
Reviewed Changes
Copilot reviewed 54 out of 54 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| testutil/client.go | Core refactoring: converts global variables to private with lazy initialization, adds getter functions, implements concurrent address resolution |
| Multiple test files | Updates all test files to use new getter functions instead of direct global variable access |
| testutil/minio.go | Adds MaxRetries configuration for improved reliability |
| t/t.go | Adds concurrent health checking for cluster startup and GOPATH validation |
| dgraph/docker-compose.yml | Improves GOPATH environment variable validation with error messages |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
ghost
reviewed
Aug 16, 2025
ef42d4e to
424ab74
Compare
3 tasks
…version is *indeed* higher
ghost
approved these changes
Aug 22, 2025
saksham115
pushed a commit
to saksham115/dgraph
that referenced
this pull request
Apr 3, 2026
saksham115
pushed a commit
to saksham115/dgraph
that referenced
this pull request
Apr 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR significantly improves performance of "t"-based testing in Dgraph
tIn general (on my M4) many tests improve time to complete by a factor of 3.
Checklist