Handle quotes while building upsert query#9412
Merged
mangalaman93 merged 2 commits intomainfrom Jun 16, 2025
Merged
Conversation
github-actions
Bot
added
area/testing
There was a problem hiding this comment.
Pull Request Overview
This pull request addresses the handling of quotes in the upsert query and fixes issue #9405 by modifying the query string construction.
- Updated query string formatting in edgraph/server.go to properly handle embedded quotes
- Added a new test (TestStringWithQuote) in dgraph/cmd/alpha/upsert_test.go to validate the change
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| edgraph/server.go | Updated query string construction to escape quotes correctly |
| dgraph/cmd/alpha/upsert_test.go | Added test to ensure quotes are handled in the upsert query correctly |
|
Running Code Quality on PRs by uploading data to Trunk will soon be removed. You can still run checks on your PRs using trunk-action - see the migration guide for more information. |
mangalaman93
force-pushed
the
aman/upsert
branch
from
f65eb4a to
7b9ffa3
Compare
mangalaman93
force-pushed
the
aman/upsert
branch
from
7b9ffa3 to
e8ad7d7
Compare
ghost
approved these changes
Jun 16, 2025
mangalaman93
force-pushed
the
aman/upsert
branch
from
e8ad7d7 to
5a7d7db
Compare
shivaji-kharse
approved these changes
Jun 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #9405