Fix aws-cli completion for ZSH#1627
Merged
abdurriq merged 1 commit intodevcontainers:mainfrom Apr 28, 2026
Merged
Conversation
Contributor
Author
|
@microsoft-github-policy-service agree |
Kaniska244
requested changes
Apr 21, 2026
Contributor
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
Thank you for the contribution. Would you kindly bump the aws-cli feature version.
The ZSH completer script provided by the aws/aws-cli repo is not set up to be used as a completer function, and thus cannot be dropped into a directory like ~/.oh-my-zsh/completions and be expected to work. This change also moves the completer to a more standard location for system-wide ZSH completions, and adds the necessary header to make it work as a completer.
daeghanelkin
force-pushed
the
fix/aws-cli-zsh-completion
branch
from
058b65c to
fdea347
Compare
Contributor
Author
|
@Kaniska244 Sorry about that, I remember reading about bumping the version and completely forgot to do it! |
Kaniska244
approved these changes
Apr 21, 2026
Contributor
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
To be further reviewed by maintainers.
abdurriq
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ZSH completer script provided by the aws/aws-cli repo is not set up to be used as a completer function, and thus cannot be dropped into a directory like
~/.oh-my-zsh/completionsand be expected to work.This change also moves the completer to a more standard location for system-wide ZSH completions, and adds the necessary header to make it work as a completer.