Skip to content

#1587 - Fix: Remove temporary Go tools directory #1588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abdurriq merged 4 commits into from
Mar 4, 2026
Merged

#1587 - Fix: Remove temporary Go tools directory #1588

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7f76ce4
Fix: Remove temporary Go tools directory
gvatsal60 Feb 22, 2026
1680f39
Merge branch 'main' into fix/#1587_go
Kaniska244 Feb 24, 2026
1343f7e
Bump go version & Fixed variable expansion
gvatsal60 Feb 28, 2026
7533c0a
Merge branch 'main' into fix/#1587_go
gvatsal60 Feb 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 10 additions & 7 deletions src/go/install.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,10 +301,11 @@ GO_TOOLS="\
if [ "${INSTALL_GO_TOOLS}" = "true" ]; then
echo "Installing common Go tools..."
export PATH=${TARGET_GOROOT}/bin:${PATH}
mkdir -p /tmp/gotools /usr/local/etc/vscode-dev-containers ${TARGET_GOPATH}/bin
cd /tmp/gotools
export GOPATH=/tmp/gotools
export GOCACHE=/tmp/gotools/cache
export GOCACHE=${GOPATH}/cache

mkdir -p ${GOPATH} /usr/local/etc/vscode-dev-containers ${TARGET_GOPATH}/bin
cd ${GOPATH}

# Use go get for versions of go under 1.16
go_install_command=install
Expand All @@ -316,10 +317,9 @@ if [ "${INSTALL_GO_TOOLS}" = "true" ]; then

(echo "${GO_TOOLS}" | xargs -n 1 go ${go_install_command} -v )2>&1 | tee -a /usr/local/etc/vscode-dev-containers/go.log

Comment thread
gvatsal60 marked this conversation as resolved.
# Move Go tools into path and clean up
if [ -d /tmp/gotools/bin ]; then
mv /tmp/gotools/bin/* ${TARGET_GOPATH}/bin/
rm -rf /tmp/gotools
# Move Go tools into path
if [ -d "${GOPATH}/bin" ]; then
mv ${GOPATH}/bin/* ${TARGET_GOPATH}/bin/
fi

# Install golangci-lint from precompiled binares
Expand All @@ -332,6 +332,9 @@ if [ "${INSTALL_GO_TOOLS}" = "true" ]; then
curl -fsSL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | \
sh -s -- -b "${TARGET_GOPATH}/bin" "v${GOLANGCILINT_VERSION}"
Comment thread
gvatsal60 marked this conversation as resolved.
fi

# Remove Go tools temp directory
rm -rf ${GOPATH}
Comment thread
gvatsal60 marked this conversation as resolved.
Outdated
Comment thread
gvatsal60 marked this conversation as resolved.
Outdated
fi


Expand Down
Loading