Skip to content

Fix silent curl failures in desktop-lite feature installation#1566

Closed
Copilot wants to merge 2 commits intocopilot/unify-user-selection-logicfrom
copilot/fix-github-actions-workflow-test-again
Closed

Fix silent curl failures in desktop-lite feature installation#1566
Copilot wants to merge 2 commits intocopilot/unify-user-selection-logicfrom
copilot/fix-github-actions-workflow-test-again

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Feb 11, 2026

The desktop-lite feature was failing during installation because curl downloads were silently failing on HTTP errors, creating corrupted zip files that caused unzip to fail with "End-of-central-directory signature not found."

Changes

  • Added -f flag to curl commands to return non-zero exit codes on HTTP errors (4xx/5xx)
  • Added explicit error handling with early exit for failed downloads:
    • Cascadia Code fonts download
    • noVNC archive download
    • websockify archive download
  • Incremented feature version to 1.3.1

Example

# Before: silently creates corrupted file on HTTP error
curl -sSL <url> -o /tmp/file.zip
unzip /tmp/file.zip  # fails with cryptic error

# After: fails fast with clear error message
if ! curl -fsSL <url> -o /tmp/file.zip; then
    echo "Failed to download <resource>"
    exit 1
fi

This prevents downstream failures from corrupted files when GitHub returns HTTP errors due to rate limiting or service issues.

Original prompt

Fix the failing GitHub Actions workflow test (desktop-lite, ubuntu:focal)
Analyze the workflow logs, identify the root cause of the failure, and implement a fix.
Job ID: 63256089501
Job URL: https://github.com/devcontainers/features/actions/runs/21908693416/job/63256089501


💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

Copilot AI changed the title [WIP] Fix failing GitHub Actions workflow test for desktop-lite Fix silent curl failures in desktop-lite feature installation Feb 11, 2026
Copilot AI requested a review from abdurriq February 11, 2026 15:07
@abdurriq abdurriq closed this Feb 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants