Skip to content

Fixes #1357#1358

Merged
AlvaroRausell merged 2 commits intodevcontainers:mainfrom
labiraus:main
Jun 18, 2025
Merged

Fixes #1357#1358
AlvaroRausell merged 2 commits intodevcontainers:mainfrom
labiraus:main

Conversation

@labiraus
Copy link
Copy Markdown
Contributor

@labiraus labiraus commented May 8, 2025

Update VS Code extension references from 'ms-azuretools.vscode-docker' to 'ms-azuretools.vscode-containers' in Docker features

…' to 'ms-azuretools.vscode-containers' in Docker features
@labiraus labiraus requested a review from a team as a code owner May 8, 2025 09:25
@labiraus
Copy link
Copy Markdown
Contributor Author

labiraus commented May 8, 2025

@microsoft-github-policy-service agree

@labiraus labiraus changed the title Update VS Code extension references from 'ms-azuretools.vscode-docker… FIXES #1357 May 8, 2025
@labiraus labiraus changed the title FIXES #1357 Fixes #1357 May 8, 2025
Copy link
Copy Markdown
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @labiraus ,

Thank you for the contribution. Would you kindly site any official documentation which suggests that ms-azuretools.vscode-docker extension has been superseded by ms-azuretools.vscode-containers?
From what I gather, the former is the extension to enable docker cli whereas the latter is the devcontainers extension. Kindly let me know if I am missing some important points here.

With Regards,
Kaniska

@charsleysa
Copy link
Copy Markdown

@labiraus according to this blog post, the existing Docker extension is becoming Container Tools
https://techcommunity.microsoft.com/blog/appsonazureblog/major-updates-to-vs-code-docker-introducing-container-tools/4400609

@labiraus
Copy link
Copy Markdown
Contributor Author

As @charsleysa has highlighted, the docker extension is being superseded by the container extension. If you download both onto your machine then the container extension will pop up with an error telling you to remove the docker extension.

Both the docker extension and container extension provide the same functionality. You may be confusing ms-azuretools.vscode-containers (container extension) with ms-vscode-remote.remote-containers (devcontainer extension)

@Kaniska244
Copy link
Copy Markdown
Contributor

As @charsleysa has highlighted, the docker extension is being superseded by the container extension. If you download both onto your machine then the container extension will pop up with an error telling you to remove the docker extension.

Both the docker extension and container extension provide the same functionality. You may be confusing ms-azuretools.vscode-containers (container extension) with ms-vscode-remote.remote-containers (devcontainer extension)

Hello @labiraus ,

Thank you for the clarification. Indeed that seems to be the case that ms-azuretools.vscode-containers is not related to devcontainers. Let me check this one a little further & take this forward for approval. I will keep you posted.

With Regards,
Kaniska

@Kaniska244 Kaniska244 self-requested a review May 14, 2025 06:45
@labiraus
Copy link
Copy Markdown
Contributor Author

@Kaniska244 is there an update on this review?

Copy link
Copy Markdown
Contributor

@Kaniska244 Kaniska244 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are fine. To be further reviewed by maintainers.

@labiraus
Copy link
Copy Markdown
Contributor Author

Any update on who still needs to review this, or if it's on hold related to microsoft/vscode-containers#43 ?

@AlvaroRausell AlvaroRausell merged commit f1ae9da into devcontainers:main Jun 18, 2025
120 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants