Docker-in-docker feature support for fedora#1328
Docker-in-docker feature support for fedora#1328sireeshajonnalagadda wants to merge 22 commits intodevcontainers:mainfrom
Conversation
Kaniska244
left a comment
Kaniska244
left a comment
There was a problem hiding this comment.
Left few minor comments. Please let me know incase of further clarifications.
| # Refresh apt lists | ||
| apt-get update | ||
|
|
||
| fi |
There was a problem hiding this comment.
Please correct the indentation for better readability.
|
|
||
| } | ||
| # Install dependencies for fedora | ||
| if ! command -v git wget which&> /dev/null; then |
There was a problem hiding this comment.
Just out of curiosity, how is this condition only passing for fedora & not for debian or ubuntu?
| apt-get update -y | ||
| apt-get install -y gnupg curl | ||
| apt-get -y install --no-install-recommends "$@" | ||
| fi |
There was a problem hiding this comment.
These installations should not be done in this apt_get_update() function. Would it possible to move them below as part of code in this code, if the package isn't included there already.
|
Hi @Kaniska244, |
| echo "Installing Moby packages..." | ||
| sudo dnf install -y moby-engine moby-cli moby-buildx --skip-unavailable | ||
|
|
||
| else |
There was a problem hiding this comment.
When does the code inside this else condition get executed ? I see here this install_docker_or_moby function called only when USE_MOBY flag is set to true. Please let me know if I am missing something.
| "features": { | ||
| "docker-in-docker": { | ||
| "iptables": "true", | ||
| "moby": "true", |
There was a problem hiding this comment.
We should have another test case also with "moby": "false" for fedora
|
HI @Kaniska244, |
Indentation mismatch in the Dockerfile for docker-in-docker install script This reverts commit 6a61aeb.
2 participants
Feature Name
Description of Changes
Extending support of Docker-in-docker feature for other linux distributions (Fedora)
As per the user request [docker-in-docker] Not working on fedora kernel > 6.11.7-300.fc41.x86_64 #1235
Changelog
Modified the install.sh to work the expected installation for Fedora
Wrote test case scenarios to meet the required checks for the Docker-in-docker
Checklist