Add custom instructions and bump versions#1317
Conversation
|
@chrmarti any input on why the Java tests are failing would be a great help too! |
|
I see #1316 will fix the Java feature. |
Ah thank you! Do you think we should wait to merge this one until that's merged? |
|
@bamurtaugh Merged the other one. I'll leave resolving the conflict up to you, so my approval will still count afterwards. 😅 |
|
Thanks @chrmarti! I just resolved the conflict (another bump in ruby feature version). |
|
Since like @chrmarti mentioned, the previous approvals should still count: But looks like GH wants another approving maintainer approval? 😄 |
|
We should be good with my approval now. I think GitHub wouldn't accept mine if I had done the merge. |
|
Failing dotnet test is filed as dotnet/sdk#47865. |
Thanks for linking! Should we merge anyways, considering this issue was already there? |
|
I think so, the git test is hung, but I don't see that in the other recent PR. I will merge now. |

Continuing from #1314