[docker-outside-of-docker] - Correction in fetching previous version from github api url#1252
Merged
ddoyle2017 merged 15 commits intodevcontainers:mainfrom Mar 26, 2025
Conversation
…from github api url
…ning to latest release
…ray, so to tackle both the scenarios in the function of fallbacking
|
This same concern happened again today with a new release. Any chance this could be reviewed and merged? |
Mathiyarasy
approved these changes
Mar 19, 2025
Contributor
Mathiyarasy
left a comment
Mathiyarasy
left a comment
There was a problem hiding this comment.
Updated the minor version
Mathiyarasy
requested changes
Mar 20, 2025
Mathiyarasy
approved these changes
Mar 24, 2025
ddoyle2017
approved these changes
Mar 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature Name
Docker-Outside-Of-DockerDescription of Changes
Docker-outside-of-DockerFeature as previously it was fetching thelatestversion in a plight to fetch thepreviousversion from theGitHub API URL, which was misleading and therefore now fetching the second element'stag_nameproperty's value inreleasesarray json for correcting the aboveChangelog
install.shfiledocker_build_compose_fallback.shfile in test case scenarios implementations of docker-outside-of-dockerChecklist