-
Notifications
You must be signed in to change notification settings - Fork 593
EOL Dotnet 6.0 #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Kaniska244
wants to merge
14
commits into
devcontainers:main
Choose a base branch
from
Kaniska244:Dotnet-EOL-6.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
EOL Dotnet 6.0 #1220
Changes from 8 commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
c5d1901
Dotnet EOL 6.0 changes
Kaniska244 064b806
Changing the dotnet version in test
Kaniska244 675952b
Reverting back some test changes
Kaniska244 e01c9ad
To check tests
Kaniska244 b4eae7e
Reverting some test changes
Kaniska244 68ae7cb
Added test to see if dotnet 6.0 still works
Kaniska244 5f248c6
Removing additonal test step for dotnet 6 test case.
Kaniska244 835a52f
Merge branch 'main' into Dotnet-EOL-6.0
Kaniska244 03e93c6
Correction based on review comments
Kaniska244 86edc82
Remove existing changes to resolve conflict.
Kaniska244 6cb6ab8
To solve the conflict
Kaniska244 8cad501
Resolving conflict
Kaniska244 56b4f0e
Resolve conflict
Kaniska244 98940ae
Merge branch 'main' into Dotnet-EOL-6.0
Kaniska244 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,24 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -e | ||
|
|
||
| # Optional: Import test library bundled with the devcontainer CLI | ||
| # See https://github.com/devcontainers/cli/blob/HEAD/docs/features/test.md#dev-container-features-test-lib | ||
| # Provides the 'check' and 'reportResults' commands. | ||
| source dev-container-features-test-lib | ||
|
|
||
| # Feature-specific tests | ||
| # The 'check' command comes from the dev-container-features-test-lib. Syntax is... | ||
| # check <LABEL> <cmd> [args...] | ||
| source dotnet_env.sh | ||
| source dotnet_helpers.sh | ||
|
|
||
| expected=$(fetch_latest_version_in_channel "6.0") | ||
|
|
||
| check ".NET Core SDK 6.0 installed" \ | ||
| is_dotnet_sdk_version_installed "$expected" | ||
|
|
||
| # Report results | ||
| # If any of the checks above exited with a non-zero exit code, the test will fail. | ||
| reportResults | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| using Newtonsoft.Json; | ||
|
|
||
| string json = """ | ||
| { | ||
| "Name": "Inception", | ||
| "ReleaseDate": "2010-07-08T00:00:00", | ||
| "Genres": [ | ||
| "Action", | ||
| "Thriller" | ||
| ] | ||
| } | ||
| """; | ||
|
|
||
| Movie? m = JsonConvert.DeserializeObject<Movie>(json); | ||
|
|
||
| if (m == default) | ||
| { | ||
| Console.WriteLine("Decoding failed!"); | ||
| } | ||
| else | ||
| { | ||
| Console.WriteLine($"Movie name: {m.Name}"); | ||
| Console.WriteLine($"Release Date: {m.ReleaseDate}"); | ||
| Console.WriteLine($"Genres: {string.Join(", ", m.Genres)}"); | ||
| } | ||
|
|
||
| class Movie | ||
| { | ||
| public string Name { get; set; } = "Default Name"; | ||
| public DateTime ReleaseDate { get; set; } | ||
| public List<string> Genres { get; set; } = new List<string>(); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| <Project Sdk="Microsoft.NET.Sdk"> | ||
|
|
||
| <PropertyGroup> | ||
| <OutputType>Exe</OutputType> | ||
| <TargetFramework>net9.0</TargetFramework> | ||
| <ImplicitUsings>enable</ImplicitUsings> | ||
| <Nullable>enable</Nullable> | ||
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.1" /> | ||
| </ItemGroup> | ||
|
|
||
| </Project> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.