Add support for Alpine to python feature#1015
Open
jonbackhaus wants to merge 63 commits intodevcontainers:mainfrom
Open
Add support for Alpine to python feature#1015jonbackhaus wants to merge 63 commits intodevcontainers:mainfrom
python feature#1015jonbackhaus wants to merge 63 commits intodevcontainers:mainfrom
Conversation
… package source file
note: the `addgroup` arguments are in a different order than `groupadd`
need to add another clause to handle Alpine; this simplifies the logic for handling both cases
…talled); refactor test script names to remove major version suffix (since it isn't specified in the associated image tag)
samruddhikhandale
requested changes
Jun 25, 2024
Member
samruddhikhandale
left a comment
samruddhikhandale
left a comment
There was a problem hiding this comment.
Amazing to see the Alpine support added for Python, thank you ✨
Reduce additional version check/s to only include 3.10 (to save time on testing at the expense of coverage, which we get elsewhere) Co-authored-by: Samruddhi Khandale <[email protected]>
- specify exact alternate version: 3.10.5 - remove checks for 3.8,3.9.13 (now OBE)
…he base image build isn't clean recent version of python:3.12 broke the install test because the APT cache wasn't clean
jonbackhaus
commented
Aug 18, 2024
Contributor
Author
jonbackhaus
left a comment
jonbackhaus
left a comment
There was a problem hiding this comment.
I believe the build issue should be fixed -- I think it was a stale caching issue in non-alpine Python images. But I'm having issues running the tests locally, so it's hard to say if the full suite is currently passing.
samruddhikhandale
requested changes
Aug 20, 2024
this is only necessary for distributions like alpine which have a (busybox) shim the previous `--upgrade` flag was not compatible with all package managers; given that alpine does not have the package installed, it can be installed through the `check_packages()` function
Contributor
Author
|
Is there additional work required to get this merged? I believe all the comments have been addressed and all tests were passing as of the last time I ran them. Thank you! |
joshspicer
reviewed
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces support of Alpine Linux to the
pythondev container feature.