Use state to persist inputs used in the post step#443
Open
iaingalloway wants to merge 1 commit intodevcontainers:mainfrom
Open
Use state to persist inputs used in the post step#443iaingalloway wants to merge 1 commit intodevcontainers:mainfrom
iaingalloway wants to merge 1 commit intodevcontainers:mainfrom
Conversation
There is a known bug in GHA actions/runner. When a node action with a post step is called via a nested composite action, the runner restores the wrong INPUT_* environment for the post step, potentially resulting in images being incorrectly pushed or not pushed, or the wrong tags being pushed. This commit uses a workaround used in the first-party action github/codeql-action, instead of using `core.getInput` in the post step, the relevant values are stored in the main step using `core.saveState`, and then loaded in the post step using `core.getState` Fixes devcontainers#442
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a known bug in GHA actions/runner. When a node action with a post step is called via a nested composite action, the runner restores the wrong INPUT_* environment for the post step, potentially resulting in images being incorrectly pushed or not pushed, or the wrong tags being pushed.
This PR uses a workaround used in the first-party action github/codeql-action, instead of using
core.getInputin the post step, the relevant values are stored in the main step usingcore.saveState, and then loaded in the post step usingcore.getStateFixes #442