Replace old Spark Jar integration tests with an acceptance test#5191
Merged
andrewnester merged 3 commits intomainfrom May 6, 2026
Merged
Replace old Spark Jar integration tests with an acceptance test#5191andrewnester merged 3 commits intomainfrom
andrewnester merged 3 commits intomainfrom
Conversation
andrewnester
requested review from
denik,
janniklasrose,
pietern and
shreyas-goenka
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
May 6, 2026
| artifacts: | ||
| my_java_code: | ||
| path: ./myjar | ||
| build: "javac PrintArgs.java && jar cvfm PrintArgs.jar META-INF/MANIFEST.MF PrintArgs.class" |
Contributor
There was a problem hiding this comment.
question - do we specifically want to test javac there or can we add a jar directly and then remove JDK requirement from our test suite and github workflows?
Contributor
Author
There was a problem hiding this comment.
We want to make sure here that building with artifacts section actually works, that it produce the artifacts which we can later correctly reference on
pietern
reviewed
May 6, 2026
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Replace old Spark Jar integration tests with an acceptance test
Why
We don't need to test the matric of DBR / Java / Spark versions anymore and instead can just rely on an acceptance test for LTS DBR
Tests
Added an acceptance test which pass on both Cloud and Local