-
Notifications
You must be signed in to change notification settings - Fork 165
Add vector_search_indexes resource (direct engine) #5123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
janniklasrose
wants to merge
45
commits into
main
Choose a base branch
from
janniklasrose/vs-index
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
45 commits
Select commit
Hold shift + click to select a range
959b0cb
One-shot with skill
janniklasrose c07e291
Fixes
janniklasrose 71d3a37
acceptance: fix stale vector-search tests from earlier vs-index work
janniklasrose 60e86ed
acceptance: add drift/deleted_remotely test for vector_search_indexes
janniklasrose de9d236
direct: satisfy exhaustruct for VectorSearchEndpointState and CreateV…
janniklasrose 69f5267
Fix dev-mode name prefixing for vector_search_indexes
janniklasrose e0e3ac3
acceptance: cover vector_search prefix in presets_name_prefix
janniklasrose 4c73247
acceptance: mark vector_search_indexes tests as RequiresUnityCatalog
janniklasrose aa9e2a9
direct: track endpoint UUID on vector search index to detect orphaning
janniklasrose 9eb36d0
phases: prompt before deleting or recreating vector search indexes
janniklasrose 713aa25
direct: wait for index deletion to complete before recreating
janniklasrose d552b36
direct: split deletion wait into WaitAfterDelete adapter method
janniklasrose 52ed4bc
phases: tailor VS index destructive prompt to delta_sync vs direct_ac…
janniklasrose e3607f1
phases: route VS index type mapping through an exhaustive switch
janniklasrose 3c39f20
direct: document the secondary endpoint lookup in DoCreate
janniklasrose 8492ed1
schema: regenerate after VS index changes
janniklasrose 0e5a274
NEXT_CHANGELOG: vector_search_indexes resource
janniklasrose ef94326
phases: revert per-type VS index destructive-action prompt
janniklasrose 25f3b7e
phases: drop the "why generic" comment on the VS index prompt
janniklasrose 011739e
testserver: drop the VS index pending-deletion buffer
janniklasrose 2c5d654
test: drop unhappy-path VS index URL case from initialize_urls_test
janniklasrose 55d564e
Revert budget_policy_id ignore and usage_policy_id schema description
janniklasrose 2dab74b
Restore usage_policy_id PLACEHOLDER description in annotations.yml
janniklasrose 80baa25
Revert run-local-node output.txt drift
janniklasrose 9599b21
acceptance: drop my_schema fixture from presets_name_prefix
janniklasrose 647e6a0
Revert unrelated comment tweak in apply.go::Delete
janniklasrose 7739af7
acceptance: drop schema reference from presets_name_prefix index name
janniklasrose c3078ea
direct: preserve index_subtype during VS index remote remap
janniklasrose d765db4
direct: treat VS index name and index_subtype as recreate-on-change
janniklasrose 89d82fe
presets: skip VS index name prefix when refs are unresolved
janniklasrose edeceb2
validate: enforce matching spec block for VS index_type
janniklasrose dcd3110
Revert "validate: enforce matching spec block for VS index_type"
janniklasrose 44ade3f
acceptance: regenerate after rebase onto main
janniklasrose 86375c6
direct: propagate endpoint UUID lookup errors for VS indexes
janniklasrose 5fe3dea
acceptance: capture VS endpoint-recreate cascade gap
janniklasrose 20fa7bc
acceptance: capture VS index endpoint_name prefixing gap
janniklasrose 18e63e9
acceptance: add bind/unbind tests for vector_search_indexes
janniklasrose a191d5e
acceptance: rename PRIMARY_KEY_PLACEHOLDER to INDEX_TYPE_PLACEHOLDER
janniklasrose 0c33818
changelog: shorten VS indexes entry
janniklasrose c4076df
direct: wait for VS index Status.Ready=true after create
janniklasrose 3d51621
Allow leaf to be prefixed if wihtout a reference
janniklasrose ec7351f
Simplify dresources/vector_search_index.go PrepareState index spec re…
janniklasrose 093b974
direct: drop empty-id state recovery, now handled by #5173
janniklasrose 41fadce
Hack: recreate index if endpoint is being recreated
janniklasrose 8f24901
Re-run 'task generate-validation'
janniklasrose File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
acceptance/bundle/deployment/bind/vector_search_index/databricks.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| bundle: | ||
| name: test-bundle-$UNIQUE_NAME | ||
|
|
||
| sync: | ||
| paths: [] | ||
|
|
||
| resources: | ||
| vector_search_indexes: | ||
| index1: | ||
| name: $INDEX_NAME | ||
| endpoint_name: $ENDPOINT_NAME | ||
| primary_key: id | ||
| index_type: DIRECT_ACCESS | ||
| direct_access_index_spec: | ||
| schema_json: '{"columns":[{"name":"id","type":"integer"}]}' |
4 changes: 4 additions & 0 deletions
4
acceptance/bundle/deployment/bind/vector_search_index/out.test.toml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
54 changes: 54 additions & 0 deletions
54
acceptance/bundle/deployment/bind/vector_search_index/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,54 @@ | ||
|
|
||
| >>> [CLI] vector-search-endpoints create-endpoint test-vs-endpoint-[UNIQUE_NAME] STANDARD | ||
| { | ||
| "name": "test-vs-endpoint-[UNIQUE_NAME]", | ||
| "endpoint_type": "STANDARD" | ||
| } | ||
|
|
||
| >>> [CLI] vector-search-indexes create-index --json {"name":"main.default.test_vs_index_[UNIQUE_NAME]","endpoint_name":"test-vs-endpoint-[UNIQUE_NAME]","primary_key":"id","index_type":"DIRECT_ACCESS","direct_access_index_spec":{"schema_json":"{\"columns\":[{\"name\":\"id\",\"type\":\"integer\"}]}"}} | ||
| { | ||
| "name": "main.default.test_vs_index_[UNIQUE_NAME]", | ||
| "endpoint_name": "test-vs-endpoint-[UNIQUE_NAME]", | ||
| "index_type": "DIRECT_ACCESS", | ||
| "primary_key": "id" | ||
| } | ||
|
|
||
| >>> [CLI] bundle deployment bind index1 main.default.test_vs_index_[UNIQUE_NAME] --auto-approve | ||
| Updating deployment state... | ||
| Successfully bound vector_search_index with an id 'main.default.test_vs_index_[UNIQUE_NAME]' | ||
| Run 'bundle deploy' to deploy changes to your workspace | ||
|
|
||
| >>> [CLI] bundle deploy --auto-approve | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default/files... | ||
| Deploying resources... | ||
| Updating deployment state... | ||
| Deployment complete! | ||
|
|
||
| >>> [CLI] vector-search-indexes get-index main.default.test_vs_index_[UNIQUE_NAME] | ||
| { | ||
| "name": "main.default.test_vs_index_[UNIQUE_NAME]", | ||
| "endpoint_name": "test-vs-endpoint-[UNIQUE_NAME]", | ||
| "index_type": "DIRECT_ACCESS", | ||
| "primary_key": "id" | ||
| } | ||
|
|
||
| >>> [CLI] bundle deployment unbind index1 | ||
| Updating deployment state... | ||
|
|
||
| >>> [CLI] bundle destroy --auto-approve | ||
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/test-bundle-[UNIQUE_NAME]/default | ||
|
|
||
| Deleting files... | ||
| Destroy complete! | ||
|
|
||
| >>> [CLI] vector-search-indexes get-index main.default.test_vs_index_[UNIQUE_NAME] | ||
| { | ||
| "name": "main.default.test_vs_index_[UNIQUE_NAME]", | ||
| "endpoint_name": "test-vs-endpoint-[UNIQUE_NAME]", | ||
| "index_type": "DIRECT_ACCESS", | ||
| "primary_key": "id" | ||
| } | ||
|
|
||
| >>> [CLI] vector-search-indexes delete-index main.default.test_vs_index_[UNIQUE_NAME] | ||
|
|
||
| >>> [CLI] vector-search-endpoints delete-endpoint test-vs-endpoint-[UNIQUE_NAME] |
27 changes: 27 additions & 0 deletions
27
acceptance/bundle/deployment/bind/vector_search_index/script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| ENDPOINT_NAME="test-vs-endpoint-$UNIQUE_NAME" | ||
| INDEX_NAME="main.default.test_vs_index_$UNIQUE_NAME" | ||
| export ENDPOINT_NAME INDEX_NAME | ||
| envsubst < databricks.yml.tmpl > databricks.yml | ||
|
|
||
| cleanup() { | ||
| trace $CLI vector-search-indexes delete-index "${INDEX_NAME}" | ||
| trace $CLI vector-search-endpoints delete-endpoint "${ENDPOINT_NAME}" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| trace $CLI vector-search-endpoints create-endpoint "${ENDPOINT_NAME}" STANDARD | jq '{name, endpoint_type}' | ||
|
|
||
| trace $CLI vector-search-indexes create-index --json "{\"name\":\"${INDEX_NAME}\",\"endpoint_name\":\"${ENDPOINT_NAME}\",\"primary_key\":\"id\",\"index_type\":\"DIRECT_ACCESS\",\"direct_access_index_spec\":{\"schema_json\":\"{\\\"columns\\\":[{\\\"name\\\":\\\"id\\\",\\\"type\\\":\\\"integer\\\"}]}\"}}" | jq '{name, endpoint_name, index_type, primary_key}' | ||
|
|
||
| trace $CLI bundle deployment bind index1 "${INDEX_NAME}" --auto-approve | ||
|
|
||
| trace $CLI bundle deploy --auto-approve | ||
|
|
||
| trace $CLI vector-search-indexes get-index "${INDEX_NAME}" | jq '{name, endpoint_name, index_type, primary_key}' | ||
|
|
||
| trace $CLI bundle deployment unbind index1 | ||
|
|
||
| trace $CLI bundle destroy --auto-approve | ||
|
|
||
| # Read the pre-defined index again (expecting it still exists and is not deleted): | ||
| trace $CLI vector-search-indexes get-index "${INDEX_NAME}" | jq '{name, endpoint_name, index_type, primary_key}' |
11 changes: 11 additions & 0 deletions
11
acceptance/bundle/deployment/bind/vector_search_index/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| Local = true | ||
| Cloud = true | ||
| RequiresUnityCatalog = true | ||
|
|
||
| Ignore = [ | ||
| ".databricks", | ||
| "databricks.yml", | ||
| ] | ||
|
|
||
| [EnvMatrix] | ||
| DATABRICKS_BUNDLE_ENGINE = ["direct"] |
17 changes: 17 additions & 0 deletions
17
acceptance/bundle/invariant/configs/vector_search_index.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| bundle: | ||
| name: test-bundle-$UNIQUE_NAME | ||
|
|
||
| resources: | ||
| vector_search_endpoints: | ||
| bar: | ||
| name: test-endpoint-$UNIQUE_NAME | ||
| endpoint_type: STANDARD | ||
| vector_search_indexes: | ||
| foo: | ||
| name: test-index-$UNIQUE_NAME | ||
| endpoint_name: ${resources.vector_search_endpoints.bar.name} | ||
| primary_key: id | ||
| index_type: DELTA_SYNC | ||
| delta_sync_index_spec: | ||
| source_table: main.default.source_$UNIQUE_NAME | ||
| pipeline_type: TRIGGERED |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
acceptance/bundle/resources/vector_search_indexes/basic/databricks.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| bundle: | ||
| name: deploy-vs-index-$UNIQUE_NAME | ||
|
|
||
| sync: | ||
| paths: [] | ||
|
|
||
| resources: | ||
| vector_search_indexes: | ||
| my_index: | ||
| name: vs-index-$UNIQUE_NAME | ||
| endpoint_name: vs-endpoint-$UNIQUE_NAME | ||
| primary_key: id | ||
| index_type: DELTA_SYNC | ||
| delta_sync_index_spec: | ||
| source_table: main.default.source_$UNIQUE_NAME | ||
| pipeline_type: TRIGGERED |
14 changes: 14 additions & 0 deletions
14
acceptance/bundle/resources/vector_search_indexes/basic/out.requests.direct.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| { | ||
| "method": "POST", | ||
| "path": "/api/2.0/vector-search/indexes", | ||
| "body": { | ||
| "delta_sync_index_spec": { | ||
| "pipeline_type": "TRIGGERED", | ||
| "source_table": "main.default.source_[UNIQUE_NAME]" | ||
| }, | ||
| "endpoint_name": "vs-endpoint-[UNIQUE_NAME]", | ||
| "index_type": "DELTA_SYNC", | ||
| "name": "vs-index-[UNIQUE_NAME]", | ||
| "primary_key": "id" | ||
| } | ||
| } |
4 changes: 4 additions & 0 deletions
4
acceptance/bundle/resources/vector_search_indexes/basic/out.test.toml
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
72 changes: 72 additions & 0 deletions
72
acceptance/bundle/resources/vector_search_indexes/basic/output.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,72 @@ | ||
|
|
||
| >>> [CLI] bundle validate | ||
| Name: deploy-vs-index-[UNIQUE_NAME] | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-[UNIQUE_NAME]/default | ||
|
|
||
| Validation OK! | ||
|
|
||
| >>> [CLI] bundle summary | ||
| Name: deploy-vs-index-[UNIQUE_NAME] | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-[UNIQUE_NAME]/default | ||
| Resources: | ||
| Vector Search Indexes: | ||
| my_index: | ||
| Name: vs-index-[UNIQUE_NAME] | ||
| URL: (not deployed) | ||
|
|
||
| >>> [CLI] vector-search-endpoints create-endpoint vs-endpoint-[UNIQUE_NAME] STANDARD | ||
| { | ||
| "id": "[UUID]", | ||
| "name": "vs-endpoint-[UNIQUE_NAME]", | ||
| "endpoint_type": "STANDARD" | ||
| } | ||
|
|
||
| >>> [CLI] bundle deploy | ||
| Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-[UNIQUE_NAME]/default/files... | ||
| Deploying resources... | ||
| Updating deployment state... | ||
| Deployment complete! | ||
|
|
||
| >>> [CLI] vector-search-indexes get-index vs-index-[UNIQUE_NAME] | ||
| { | ||
| "name": "vs-index-[UNIQUE_NAME]", | ||
| "endpoint_name": "vs-endpoint-[UNIQUE_NAME]", | ||
| "index_type": "DELTA_SYNC", | ||
| "primary_key": "id" | ||
| } | ||
|
|
||
| >>> [CLI] bundle summary | ||
| Name: deploy-vs-index-[UNIQUE_NAME] | ||
| Target: default | ||
| Workspace: | ||
| User: [USERNAME] | ||
| Path: /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-[UNIQUE_NAME]/default | ||
| Resources: | ||
| Vector Search Indexes: | ||
| my_index: | ||
| Name: vs-index-[UNIQUE_NAME] | ||
| URL: (not deployed) | ||
|
|
||
| >>> print_requests.py //vector-search/indexes | ||
|
|
||
| >>> [CLI] bundle destroy --auto-approve | ||
| The following resources will be deleted: | ||
| delete resources.vector_search_indexes.my_index | ||
|
|
||
| This action will result in the deletion of the following Vector Search indexes. | ||
| For Delta Sync indexes, the source Delta table is preserved but the embedding pipeline is removed. | ||
| For Direct Access indexes, all upserted vectors are permanently lost: | ||
| delete resources.vector_search_indexes.my_index | ||
|
|
||
| All files and directories at the following location will be deleted: /Workspace/Users/[USERNAME]/.bundle/deploy-vs-index-[UNIQUE_NAME]/default | ||
|
|
||
| Deleting files... | ||
| Destroy complete! | ||
|
|
||
| >>> [CLI] vector-search-endpoints delete-endpoint vs-endpoint-[UNIQUE_NAME] |
26 changes: 26 additions & 0 deletions
26
acceptance/bundle/resources/vector_search_indexes/basic/script
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| envsubst < databricks.yml.tmpl > databricks.yml | ||
| endpoint_name="vs-endpoint-${UNIQUE_NAME}" | ||
|
|
||
| cleanup() { | ||
| trace $CLI bundle destroy --auto-approve | ||
| trace $CLI vector-search-endpoints delete-endpoint "${endpoint_name}" | ||
| rm -f out.requests.txt | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| trace $CLI bundle validate | ||
|
|
||
| trace $CLI bundle summary | ||
|
|
||
| trace $CLI vector-search-endpoints create-endpoint "${endpoint_name}" STANDARD | jq '{id, name, endpoint_type}' | ||
|
|
||
| rm -f out.requests.txt | ||
| trace $CLI bundle deploy | ||
|
|
||
| # Get index details | ||
| index_name="vs-index-${UNIQUE_NAME}" | ||
| trace $CLI vector-search-indexes get-index "${index_name}" | jq '{name, endpoint_name, index_type, primary_key}' | ||
|
|
||
| trace $CLI bundle summary | ||
|
|
||
| trace print_requests.py //vector-search/indexes > out.requests.$DATABRICKS_BUNDLE_ENGINE.json | ||
1 change: 1 addition & 0 deletions
1
acceptance/bundle/resources/vector_search_indexes/basic/test.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| # All configuration inherited from parent test.toml |
19 changes: 19 additions & 0 deletions
19
acceptance/bundle/resources/vector_search_indexes/drift/columns_to_sync/databricks.yml.tmpl
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| bundle: | ||
| name: drift-vs-index-columns-$UNIQUE_NAME | ||
|
|
||
| sync: | ||
| paths: [] | ||
|
|
||
| resources: | ||
| vector_search_indexes: | ||
| my_index: | ||
| name: vs-index-$UNIQUE_NAME | ||
| endpoint_name: vs-endpoint-$UNIQUE_NAME | ||
| primary_key: id | ||
| index_type: DELTA_SYNC | ||
| delta_sync_index_spec: | ||
| source_table: main.default.source_$UNIQUE_NAME | ||
| pipeline_type: TRIGGERED | ||
| columns_to_sync: | ||
| - id | ||
| - text |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you create it as part of the same bundle and refer to it in the index?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no strong feeling either way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we are strict about it, we have already resources combining both (see catalogs or database_catalogs for example).
Having them together helps us to test the actual use case users will have + cleaning up is a bit easier too